Project

General

Profile

Actions

Bug #13295

open

Incorrect function parameters for ``get_dpinger_status()`` call in ``gwlb.inc``

Added by → luckman212 about 2 months ago. Updated about 2 months ago.

Status:
Pull Request Review
Priority:
Normal
Assignee:
-
Category:
Gateway Monitoring
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
22.11
Release Notes:
Default
Affected Version:
Affected Architecture:

Description

There seems to be an error in gwlb.inc around line 479. The call to get_dpinger_status() has the $action_disable arg at position 2, but the function definition needs it at position 3. So, the bool is actually passed as param 2, which is supposed to be an array ($gways).

Not sure what problems this may have caused, but it seems incorrect.

PR: https://github.com/pfsense/pfsense/pull/4604

Actions #1

Updated by Jim Pingle about 2 months ago

  • Subject changed from Incorrect function params for get_dpinger_status() call in gwlb.inc to Incorrect function parameters for ``get_dpinger_status()`` call in ``gwlb.inc``
  • Target version set to 2.7.0
  • Plus Target Version set to 22.09
Actions #2

Updated by Jim Pingle about 2 months ago

  • Plus Target Version changed from 22.09 to 22.11
Actions

Also available in: Atom PDF