Project

General

Profile

Actions
Copy link

Bug #13295

closed

Incorrect function parameters for ``get_dpinger_status()`` call in ``gwlb.inc``

Added by → luckman212 over 2 years ago. Updated almost 2 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Jim Pingle
Category:
Gateway Monitoring
Target version:
2.7.0
Start date:
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
23.01
Release Notes:
Default
Affected Version:
Affected Architecture:

Description

There seems to be an error in gwlb.inc around line 479. The call to get_dpinger_status() has the $action_disable arg at position 2, but the function definition needs it at position 3. So, the bool is actually passed as param 2, which is supposed to be an array ($gways).

Not sure what problems this may have caused, but it seems incorrect.

PR: https://github.com/pfsense/pfsense/pull/4604

Actions
Copy link
 #1

Updated by Jim Pingle over 2 years ago

  • Subject changed from Incorrect function params for get_dpinger_status() call in gwlb.inc to Incorrect function parameters for ``get_dpinger_status()`` call in ``gwlb.inc``
  • Target version set to 2.7.0
  • Plus Target Version set to 22.09
Actions
Copy link
 #2

Updated by Jim Pingle over 2 years ago

  • Plus Target Version changed from 22.09 to 22.11
Actions
Copy link
 #3

Updated by Jim Pingle about 2 years ago

  • Plus Target Version changed from 22.11 to 23.01
Actions
Copy link
 #4

Updated by Jim Pingle about 2 years ago

  • Status changed from Pull Request Review to Feedback
  • Assignee set to Jim Pingle

PR merged

Actions
Copy link
 #5

Updated by Jim Pingle almost 2 years ago

  • Status changed from Feedback to Resolved

Closing as it seems to be correct now in the code, even if it didn't impact much (if anything), can always reopen if something changed in a negative way as a result.

Actions
Copy link

Also available in: Atom PDF