Bug #13295
closed
Incorrect function parameters for ``get_dpinger_status()`` call in ``gwlb.inc``
Added by → luckman212 over 2 years ago.
Updated almost 2 years ago.
Category:
Gateway Monitoring
Plus Target Version:
23.01
Description
There seems to be an error in gwlb.inc
around line 479. The call to get_dpinger_status()
has the $action_disable
arg at position 2, but the function definition needs it at position 3. So, the bool is actually passed as param 2, which is supposed to be an array ($gways
).
Not sure what problems this may have caused, but it seems incorrect.
PR: https://github.com/pfsense/pfsense/pull/4604
- Subject changed from Incorrect function params for get_dpinger_status() call in gwlb.inc to Incorrect function parameters for ``get_dpinger_status()`` call in ``gwlb.inc``
- Target version set to 2.7.0
- Plus Target Version set to 22.09
- Plus Target Version changed from 22.09 to 22.11
- Plus Target Version changed from 22.11 to 23.01
- Status changed from Pull Request Review to Feedback
- Assignee set to Jim Pingle
- Status changed from Feedback to Resolved
Closing as it seems to be correct now in the code, even if it didn't impact much (if anything), can always reopen if something changed in a negative way as a result.
Also available in: Atom
PDF