Project

General

Profile

Actions
Copy link

Feature #13388

closed
SW JP

Support for international characters in the AutoConfigBackup Hint/Identifier field

Feature #13388: Support for international characters in the AutoConfigBackup Hint/Identifier field

Added by Steve Wheeler about 4 years ago. Updated over 3 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Jim Pingle
Category:
Auto Configuration Backup
Target version:
2.7.0
Start date:
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
23.01
Release Notes:
Default

Description

Using unexpected characters in the Hint/Identifier field results in an invalid xml error.

For example using the value "Testü" results in:

Aug 2 13:24:53     php-fpm     29253     /services_acb_settings.php: Configuration Change: admin2@172.21.16.5 (Local Database): AutoConfigBackup settings updated
Aug 2 13:24:53     php-fpm     29253     /services_acb_settings.php: XML error: Undeclared entity error at line 92 in /conf/config.xml
Aug 2 13:24:53     php-fpm     29253     /services_acb_settings.php: pfSense is restoring the configuration /cf/conf/backup/config-1659443081.xml
Aug 2 13:24:53     php-fpm     29253     /services_acb_settings.php: New alert found: pfSense is restoring the configuration /cf/conf/backup/config-1659443081.xml

Tested:

2.7.0-DEVELOPMENT (amd64)
built on Fri Jul 29 06:15:24 UTC 2022
FreeBSD 12.3-STABLE

Also fails in 2.6.

JP Updated by Jim Pingle almost 4 years ago Actions
Copy link
 #1

  • Plus Target Version changed from 22.11 to 23.01

JP Updated by Jim Pingle almost 4 years ago Actions
Copy link
 #2

  • Assignee set to Jim Pingle

JP Updated by Jim Pingle almost 4 years ago Actions
Copy link
 #3

  • Status changed from New to Feedback
  • % Done changed from 0 to 100

Applied in changeset commit:54115a67546fcfbe32c7ec5433fb8a0d3661c808.

DZ Updated by Danilo Zrenjanin almost 4 years ago Actions
Copy link
 #4

  • Status changed from Feedback to Resolved

I was able to recreate the issue on the 22.05.

It worked as expected when I tested it against:

23.01-DEVELOPMENT (amd64)
built on Fri Dec 02 06:04:48 UTC 2022
FreeBSD 14.0-CURRENT

I am marking this ticket resolved.

JP Updated by Jim Pingle over 3 years ago Actions
Copy link
 #5

  • Tracker changed from Bug to Feature
  • Subject changed from ACB: incorrect handling of international characters in the Hint/Identifier field to Support for international characters in the AutoConfigBackup Hint/Identifier field
  • Affected Version deleted (2.7.x)
  • Affected Architecture deleted (All)

Updating subject for release notes.

Actions
Copy link

Also available in: Atom