Project

General

Profile

Actions
Copy link

Todo #13398

closed

Information box on ``status_ipsec.php`` says "IPsec not enabled" even when a tunnel is established

Added by Chris W over 2 years ago. Updated almost 2 years ago.

Status:
Resolved
Priority:
Low
Assignee:
Christopher Cope
Category:
IPsec
Target version:
2.7.0
Start date:
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
23.01
Release Notes:
Default

Description

It appears that the default state for the info button is expanded when IPsec is disabled, and closed when a tunnel is enabled and running. However, if expanded while a tunnel is enabled, it still reports that the IPsec is disabled. If possible, basing the button text field (or whether it even shows at all) on the presence of any P1's, or the charon status, would avert confusion (this was brought up to me today in a TAC call today) as to why the Status page reports that a tunnel is established and passing traffic, but the information button still says IPsec isn't enabled. This applies to both CE and Plus.

Files

Download all files
Screenshot from 2022-08-05 15-48-55.png (11.9 KB) Screenshot from 2022-08-05 15-48-55.png Chris W, 08/05/2022 07:41 PM
clipboard-202209171030-uppff.png (18 KB) clipboard-202209171030-uppff.png Lev Prokofev, 09/17/2022 02:30 AM
clipboard-202209171032-c4tve.png (24.1 KB) clipboard-202209171032-c4tve.png Lev Prokofev, 09/17/2022 02:32 AM
Actions
Copy link
 #1

Updated by Jim Pingle over 2 years ago

  • Project changed from pfSense Plus to pfSense
  • Category changed from IPsec to IPsec
  • Target version set to 2.7.0
  • Plus Target Version set to 22.11

Should be easy enough to fix, it's already doing a test of enabled/disabled there just above where it prints the info block on line 647 ( source:src/usr/local/www/status_ipsec.php#L647 ). It could probably be changed to omit the info block entirely when it's enabled. The link to configure IPsec is redundant considering there is already a link in the shortcuts on the breadcrumb bar.

Actions
Copy link
 #2

Updated by Christopher Cope about 2 years ago

  • Status changed from New to Pull Request Review
  • Assignee set to Christopher Cope
Actions
Copy link
 #3

Updated by Lev Prokofev about 2 years ago

Looks better, no more info button if it is enabled

if disabled

if enabled

Actions
Copy link
 #4

Updated by Jim Pingle about 2 years ago

  • Plus Target Version changed from 22.11 to 23.01
Actions
Copy link
 #5

Updated by Christopher Cope about 2 years ago

  • Status changed from Pull Request Review to Feedback
  • % Done changed from 0 to 100

Merged.

Actions
Copy link
 #6

Updated by Jim Pingle almost 2 years ago

  • Subject changed from Blue information button in Status > IPsec says "IPsec not enabled" even when a tunnel is established to Information box on ``status_ipsec.php`` says "IPsec not enabled" even when a tunnel is established
  • Status changed from Feedback to Resolved

Info block now only contains a link to configure IPsec no matter what the current IPsec state is, which is the intended result.

Updating subject for release notes.

Actions
Copy link

Also available in: Atom PDF