Bug #13447
closed
Double Nmap and NMap entries in Diagnostics menu
0%
Description
I'm not sure when it happened, possibly after updating from pfsense+ 22.01 to 22.05, but I now have two nmap items in my Diagnostics menu, one uppercase, one lowercase. See attached screenshot.
Clicking the uppercase one results in a mostly empty/broken UI.
I installed the nmap packages ages ago, before 22.01 even.
It feels to me like something incorrectly did a case-sensitive vs case-insensitive compare during some migration and this was the result.
Files
Updated by Kris Phillips over 2 years ago
Hello Sean,
I installed the NMap package and am unable to reproduce this issue. Likely your config has two menu items and potentially an older version of the package had different capitalization or something. I would recommend backing up your config, removing the extra menu item that is broken, and then restoring the config. However, I don't believe this is a bug as I cannot recreate this condition with the NMap package.
Updated by Sean McBride over 2 years ago
...Likely your config has two menu items...
I have backups for exported configs...
The one from 2022-05-04 has only the lowercase variant:
<menu>
<name>Nmap</name>
<section>Diagnostics</section>
<configfile>nmap.xml</configfile>
</menu>
the next one I have, from 2022-06-01, had an additional section added (uppercase variant):
<menu>
<name>NMap</name>
<section>Diagnostics</section>
<configfile>nmap.xml</configfile>
</menu>
Notably, on 2022-05-31 our pfsense hardware died and we switched to our backup device by restoring from a backup config.
This was all on pfsense+ 22.01, so we can absolve the 22.05 upgrade from creating these duplicates (though it could have handled them better, perhaps by deleting one).
potentially an older version of the package had different capitalization or something.
That's my guess too.
I would recommend backing up your config, removing the extra menu item that is broken, and then restoring the config.
You mean just cut out the uppercase variant above?
However, I don't believe this is a bug as I cannot recreate this condition with the NMap package.
Well, I think it's very much a bug, just one that does not yet have known reproduction steps. :)
Updated by Danilo Zrenjanin over 2 years ago
You mean just cut out the uppercase variant above?
That's right. Delete everything between <menu>...</menu> tags (including tags themselves). Save changes and restore configuration with the edited file.
Well, I think it's very much a bug, just one that does not yet have known reproduction steps. :)
Most of the issues after the upgrade are related to the packages. The best practice is to remove all the packages before the upgrade and re-installing them once the upgrade completes. Alternatively, you can perform a clean install and then restore your configuration.
We would need clear steps to reproduce the issue to call it a bug.
Updated by Kris Phillips over 2 years ago
Danilo Zrenjanin wrote in #note-3:
You mean just cut out the uppercase variant above?
That's right. Delete everything between <menu>...</menu> tags (including tags themselves). Save changes and restore configuration with the edited file.
Well, I think it's very much a bug, just one that does not yet have known reproduction steps. :)
Most of the issues after the upgrade are related to the packages. The best practice is to remove all the packages before the upgrade and re-installing them once the upgrade completes. Alternatively, you can perform a clean install and then restore your configuration.
We would need clear steps to reproduce the issue to call it a bug.
I agree. This should be marked as Rejected or Not a Bug.
Updated by Jim Pingle over 2 years ago
- Status changed from New to Not a Bug
When the package is (un/re)installing it only matches its same exact menu string when checking if an old entry should be removed or replaced. If the menu string changes in a new version of the package, upgrading works fine but restoring an older configuration means it can't ever match that string properly since there is no package to "remove" at that point, it's installing the new package to start with. Thus the old entry must be removed from the configuration manually in these rare cases.