Project

General

Profile

Actions
Copy link

Bug #13493

closed

Several advanced DHCP6 client options do not inform the user when rejecting invalid input

Added by Flole Systems about 2 years ago. Updated almost 2 years ago.

Status:
Resolved
Priority:
Very Low
Assignee:
Jim Pingle
Category:
Interfaces
Target version:
2.7.0
Start date:
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
23.01
Release Notes:
Default
Affected Version:
Affected Architecture:

Description

When entering "F" for example ad id-assoc pd ID in the interfaces Tab and saving it magically disappears without any error. Either an error should be shown or only numeric values should be accepted for that textbox.

Actions
Copy link
 #1

Updated by Danilo Zrenjanin about 2 years ago

  • Priority changed from Normal to Very Low

Yes, I can replicate this on the:

22.05-RELEASE (amd64)
built on Wed Jun 22 18:56:13 UTC 2022
FreeBSD 12.3-STABLE

https://www.freebsd.org/cgi/man.cgi?query=dhcp6c.conf&apropos=0&sektion=0&manpath=FreeBSD+10.3-RELEASE+and+Ports&arch=default&format=html#end

ID is a decimal number of IAID.  If omitted, the value 0 will be used by default.

The same issue appears when defining non-numerical ID in `na' (non-temporary address allocation) and `pd'(prefix delegation) filed.

Having input validation for these fields would be helpful.

Actions
Copy link
 #2

Updated by Danilo Zrenjanin about 2 years ago

  • Status changed from New to Confirmed
Actions
Copy link
 #3

Updated by Jim Pingle about 2 years ago

  • Plus Target Version changed from 22.11 to 23.01
Actions
Copy link
 #4

Updated by Jim Pingle almost 2 years ago

  • Assignee set to Jim Pingle

Looks like several fields get tested to ensure they are numeric ints before being stored, but don't have corresponding checks in places where they can generate input errors.

These are not all together in the code, this is just the fields I found collected together:

// Under a block of code that runs when $_POST['type6'] == "dhcp6" :
                if (is_numericint($_POST['adv_dhcp6_id_assoc_statement_address_id'])) {
                    $wancfg['adv_dhcp6_id_assoc_statement_address_id'] = $_POST['adv_dhcp6_id_assoc_statement_address_id'];
                }
                if (is_numericint($_POST['adv_dhcp6_id_assoc_statement_prefix_id'])) {
                    $wancfg['adv_dhcp6_id_assoc_statement_prefix_id'] = $_POST['adv_dhcp6_id_assoc_statement_prefix_id'];
                }
                if (is_numericint($_POST['adv_dhcp6_prefix_interface_statement_sla_id'])) {
                    $wancfg['adv_dhcp6_prefix_interface_statement_sla_id'] = $_POST['adv_dhcp6_prefix_interface_statement_sla_id'];
                }
                if (is_numericint($_POST['adv_dhcp6_prefix_interface_statement_sla_len'])) {
                    $wancfg['adv_dhcp6_prefix_interface_statement_sla_len'] = $_POST['adv_dhcp6_prefix_interface_statement_sla_len'];
                }

Actions
Copy link
 #5

Updated by Jim Pingle almost 2 years ago

  • Status changed from Confirmed to Feedback
  • % Done changed from 0 to 100
Actions
Copy link
 #6

Updated by Flole Systems almost 2 years ago

Wouldn't it be possible to limit the possible characters in the web interface aswell? Using the HTML5 attribute type="number" it should prevent any non-numbers to be entered. Or should it be put into a separate issue as this can most likely be added at multiple other places aswell?

Actions
Copy link
 #7

Updated by Jim Pingle almost 2 years ago

Client-side validation in JS could probably be done to help guide users toward valid input, but that should be a separate issue if there isn't one already. Whether or not it works on that specific type of form field is the question. Ultimately we need the server-side validation in place first (this issue) because we can't trust client validation on its own, as clients themselves can be malicious.

Actions
Copy link
 #8

Updated by Jim Pingle almost 2 years ago

  • Subject changed from "id-assoc pd ID" allows non-numbers to be entered to Several advanced DHCP6 client options do not inform the user when rejecting invalid input

Updating subject for release notes.

Actions
Copy link
 #9

Updated by Jim Pingle almost 2 years ago

  • Status changed from Feedback to Resolved

Working as expected now

Actions
Copy link

Also available in: Atom PDF