Bug #1353
Number of queues possible
100%
Description
ALTQ algorithm for PRIQ has a forced 15 queue limitation.
While the other algorithms are forced to a 4096 queue limit build time limit.
Triggered by http://forum.pfsense.org/index.php/topic,34435.0.html it would be nice to have the GUI spit out a nice error message when limit reached or remove the limit at all if possible.
Associated revisions
PRIQ queue array check. Issue #1353
Shaper check prio only for CBQ/FAIRQ/PRIQ. Issue #1353
CBQ queue prio check fix. Issue #1353
History
#1
Updated by Ermal Luçi almost 10 years ago
- Target version changed from 2.0 to 2.1
This is not so critical for 2.0
#2
Updated by Chris Buechler about 9 years ago
- Target version deleted (
2.1)
#3
Updated by Viktor Gurov 11 months ago
PRIQ also doesn't allow the use of the same priority for more than one queue:
pfctl: q3 does not have a unique priority on interface vtnet0 /tmp/rules.debug:50: errors in queue definition
#define PRIQ_MAXPRI 16 /* upper limit of the number of priorities */
Input validation fix:
https://github.com/pfsense/pfsense/pull/4327
#4
Updated by Jim Pingle 11 months ago
- Status changed from New to Pull Request Review
- Target version set to 2.5.0
#5
Updated by Renato Botelho 10 months ago
- Status changed from Pull Request Review to Feedback
- Assignee set to Renato Botelho
- % Done changed from 0 to 100
PR has been merged. Thanks!
#6
Updated by Viktor Gurov 10 months ago
error on the latest snapshot:
[11-Jun-2020 09:54:05 Europe/Moscow] PHP Warning: Invalid argument supplied for foreach() in /etc/inc/shaper.inc on line 1576
Need to check for $parent->queues array first,
Fix:
https://github.com/pfsense/pfsense/pull/4353
#7
Updated by Jim Pingle 10 months ago
- Status changed from Feedback to Pull Request Review
#8
Updated by Renato Botelho 10 months ago
- Status changed from Pull Request Review to Feedback
PR has been merged. Thanks!
#9
Updated by Viktor Gurov 9 months ago
Check for priority value duplication only for CBQ/FAIRQ/PRIQ queues:
https://github.com/pfsense/pfsense/pull/4387
otherwise it tries to check HFSC for prio duplication
#10
Updated by Jim Pingle 9 months ago
- Status changed from Feedback to Pull Request Review
#11
Updated by Renato Botelho 9 months ago
- Status changed from Pull Request Review to Feedback
PR has been merged. Thanks!
#12
Updated by Steve Beaver 6 months ago
- Status changed from Feedback to Resolved
#13
Updated by Viktor Gurov 6 months ago
- Status changed from Resolved to New
unique priority is mandatory now, which is incorrect
from https://www.freebsd.org/cgi/man.cgi?query=pf.conf&apropos=0&sektion=0&manpath=FreeBSD+12.1-RELEASE+and+Ports&arch=default&format=html:
priq Priority Queueing. Queues are flat attached to the interface, thus, queues cannot have further child queues. Each queue has a unique priority assigned, ranging from 0 to 15. Packets in the queue with the highest priority are processed first.
same for FAIRQ
but in case of CBQ priority can be the same for different queues
Fix:
https://gitlab.netgate.com/pfSense/pfSense/-/merge_requests/19
#14
Updated by Renato Botelho 6 months ago
- Status changed from New to Pull Request Review
#15
Updated by Renato Botelho 6 months ago
- Status changed from Pull Request Review to Feedback
PR has bene merged. Thanks!
#16
Updated by Max Leighton 5 months ago
- Status changed from Feedback to Resolved
Tested in:
2.5.0-DEVELOPMENT (amd64)
built on Fri Nov 20 13:05:16 EST 2020
FreeBSD 12.2-STABLE
Working as expected. Creating a queue with the same name or priority as another queue triggers the following errors:
The following input errors were detected:
A queue with the same name already exists.
The priority 15 is already used by queue x.
Marking as resolved.
PRIQ queue input validation. Issue #1353