Project

General

Profile

Bug #1353

Number of queues possible

Added by Ermal Luçi over 9 years ago. Updated 2 months ago.

Status:
Feedback
Priority:
Normal
Category:
Traffic Shaper (ALTQ)
Target version:
Start date:
03/15/2011
Due date:
% Done:

100%

Estimated time:
Affected Version:
All
Affected Architecture:

Description

ALTQ algorithm for PRIQ has a forced 15 queue limitation.
While the other algorithms are forced to a 4096 queue limit build time limit.

Triggered by http://forum.pfsense.org/index.php/topic,34435.0.html it would be nice to have the GUI spit out a nice error message when limit reached or remove the limit at all if possible.

Associated revisions

Revision b0f0993d (diff)
Added by Viktor Gurov 3 months ago

PRIQ queue input validation. Issue #1353

Revision cd0c9e11 (diff)
Added by Viktor Gurov 3 months ago

PRIQ queue array check. Issue #1353

Revision 00bf92ce (diff)
Added by Viktor Gurov 3 months ago

Shaper check prio only for CBQ/FAIRQ/PRIQ. Issue #1353

History

#1 Updated by Ermal Luçi over 9 years ago

  • Target version changed from 2.0 to 2.1

This is not so critical for 2.0

#2 Updated by Chris Buechler over 8 years ago

  • Target version deleted (2.1)

#3 Updated by Viktor Gurov 4 months ago

PRIQ also doesn't allow the use of the same priority for more than one queue:

pfctl: q3 does not have a unique priority on interface vtnet0
/tmp/rules.debug:50: errors in queue definition

https://github.com/pfsense/FreeBSD-src/blob/ce9563d5729455de9a9e988d20aa21da79799f47/sys/net/altq/altq_priq.h#L43:

#define    PRIQ_MAXPRI    16    /* upper limit of the number of priorities */

Input validation fix:
https://github.com/pfsense/pfsense/pull/4327

#4 Updated by Jim Pingle 4 months ago

  • Status changed from New to Pull Request Review
  • Target version set to 2.5.0

#5 Updated by Renato Botelho 3 months ago

  • Status changed from Pull Request Review to Feedback
  • Assignee set to Renato Botelho
  • % Done changed from 0 to 100

PR has been merged. Thanks!

#6 Updated by Viktor Gurov 3 months ago

error on the latest snapshot:

[11-Jun-2020 09:54:05 Europe/Moscow] PHP Warning:  Invalid argument supplied for foreach() in /etc/inc/shaper.inc on line 1576

Need to check for $parent->queues array first,
Fix:
https://github.com/pfsense/pfsense/pull/4353

#7 Updated by Jim Pingle 3 months ago

  • Status changed from Feedback to Pull Request Review

#8 Updated by Renato Botelho 3 months ago

  • Status changed from Pull Request Review to Feedback

PR has been merged. Thanks!

#9 Updated by Viktor Gurov 3 months ago

Check for priority value duplication only for CBQ/FAIRQ/PRIQ queues:
https://github.com/pfsense/pfsense/pull/4387

otherwise it tries to check HFSC for prio duplication

#10 Updated by Jim Pingle 2 months ago

  • Status changed from Feedback to Pull Request Review

#11 Updated by Renato Botelho 2 months ago

  • Status changed from Pull Request Review to Feedback

PR has been merged. Thanks!

Also available in: Atom PDF