Bug #1353: Number of queues possible - pfSense - pfSense bugtracker

Actions

Copy link

Bug #1353

closed

Number of queues possible

Added by Ermal Luçi almost 14 years ago. Updated about 4 years ago.

Status:

Resolved

Priority:

Normal

Assignee:

Renato Botelho

Category:

Traffic Shaper (ALTQ)

Target version:

2.5.0

Start date:

03/15/2011

Due date:

% Done:

100%

Estimated time:

Plus Target Version:

Release Notes:

Affected Version:

All

Affected Architecture:

Description

ALTQ algorithm for PRIQ has a forced 15 queue limitation.
While the other algorithms are forced to a 4096 queue limit build time limit.

Triggered by http://forum.pfsense.org/index.php/topic,34435.0.html it would be nice to have the GUI spit out a nice error message when limit reached or remove the limit at all if possible.

Actions

Copy link

Updated by Ermal Luçi over 13 years ago

Target version changed from 2.0 to 2.1

This is not so critical for 2.0

Actions

Copy link

Updated by Chris Buechler almost 13 years ago

Target version deleted (~~2.1~~)

Actions

Copy link

Updated by Viktor Gurov over 4 years ago

PRIQ also doesn't allow the use of the same priority for more than one queue:

pfctl: q3 does not have a unique priority on interface vtnet0
/tmp/rules.debug:50: errors in queue definition

https://github.com/pfsense/FreeBSD-src/blob/ce9563d5729455de9a9e988d20aa21da79799f47/sys/net/altq/altq_priq.h#L43:

#define    PRIQ_MAXPRI    16    /* upper limit of the number of priorities */

Input validation fix:
https://github.com/pfsense/pfsense/pull/4327

Actions

Copy link

Updated by Jim Pingle over 4 years ago

Status changed from New to Pull Request Review
Target version set to 2.5.0

Actions

Copy link

Updated by Renato Botelho over 4 years ago

Status changed from Pull Request Review to Feedback
Assignee set to Renato Botelho
% Done changed from 0 to 100

PR has been merged. Thanks!

Actions

Copy link

Updated by Viktor Gurov over 4 years ago

error on the latest snapshot:

[11-Jun-2020 09:54:05 Europe/Moscow] PHP Warning:  Invalid argument supplied for foreach() in /etc/inc/shaper.inc on line 1576

Need to check for $parent->queues array first,
Fix:
https://github.com/pfsense/pfsense/pull/4353

Actions

Copy link

Updated by Jim Pingle over 4 years ago

Status changed from Feedback to Pull Request Review

Actions

Copy link

Updated by Renato Botelho over 4 years ago

Status changed from Pull Request Review to Feedback

PR has been merged. Thanks!

Actions

Copy link

Updated by Viktor Gurov over 4 years ago

Check for priority value duplication only for CBQ/FAIRQ/PRIQ queues:
https://github.com/pfsense/pfsense/pull/4387

otherwise it tries to check HFSC for prio duplication

Actions

Copy link

#10

Updated by Jim Pingle over 4 years ago

Status changed from Feedback to Pull Request Review

Actions

Copy link

#11

Updated by Renato Botelho over 4 years ago

Status changed from Pull Request Review to Feedback

PR has been merged. Thanks!

Actions

Copy link

#12

Updated by Anonymous about 4 years ago

Status changed from Feedback to Resolved

Actions

Copy link

#13

Updated by Viktor Gurov about 4 years ago

Status changed from Resolved to New

unique priority is mandatory now, which is incorrect
from https://www.freebsd.org/cgi/man.cgi?query=pf.conf&apropos=0&sektion=0&manpath=FreeBSD+12.1-RELEASE+and+Ports&arch=default&format=html:

priq  Priority Queueing.  Queues are flat attached    to the interface,
       thus, queues    cannot have further child queues.  Each    queue has a
       unique priority assigned, ranging from 0 to 15.  Packets in the
       queue with the highest priority are processed first.

same for FAIRQ

but in case of CBQ priority can be the same for different queues

Fix:
https://gitlab.netgate.com/pfSense/pfSense/-/merge_requests/19

Actions

Copy link

#14