Project

General

Profile

Actions
Copy link

Regression #13627

closed

Feature #13446: Upgrade PHP from 7.4 to 8.1

PHP: Easyrule from the firewall log

Added by Steve Wheeler over 1 year ago. Updated over 1 year ago.

Status:
Resolved
Priority:
Normal
Assignee:
Jim Pingle
Category:
Rules / NAT
Target version:
2.7.0
Start date:
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
23.01
Release Notes:
Force Exclusion
Affected Version:
2.7.0
Affected Architecture:
All

Description

Creating an easyrule using the button in the firewall log throws a php error:

Fatal error: Uncaught TypeError: Cannot access offset of type string on string in /etc/inc/easyrule.inc:60 Stack trace: #0 /etc/inc/easyrule.inc(370): easyrule_find_rule_interface('lan') #1 /usr/local/www/easyrule.php(49): easyrule_parse_block('lan', '192.168.167.50', 'inet') #2 {main} thrown in /etc/inc/easyrule.inc on line 60 PHP ERROR: Type: 1, File: /etc/inc/easyrule.inc, Line: 60, Message: Uncaught TypeError: Cannot access offset of type string on string in /etc/inc/easyrule.inc:60 Stack trace: #0 /etc/inc/easyrule.inc(370): easyrule_find_rule_interface('lan') #1 /usr/local/www/easyrule.php(49): easyrule_parse_block('lan', '192.168.167.50', 'inet') #2 {main} thrown

Tested: 2.7.0.a.20221103.0600

Actions
Copy link
 #1

Updated by Christopher Cope over 1 year ago

  • Status changed from New to Pull Request Review
  • Assignee set to Christopher Cope

https://gitlab.netgate.com/pfSense/pfSense/-/merge_requests/916

This only happens if there are no OpenVPN servers or clients defined.

Actions
Copy link
 #2

Updated by Danilo Zrenjanin over 1 year ago

Tested the patch against:

2.7.0-DEVELOPMENT (amd64)
built on Fri Nov 04 06:05:19 UTC 2022
FreeBSD 14.0-CURRENT

I was able to add an easy rule from the firewall after adding the patch.

Actions
Copy link
 #3

Updated by Jim Pingle over 1 year ago

  • Parent task set to #13446
  • Release Notes changed from Default to Force Exclusion
Actions
Copy link
 #4

Updated by Jim Pingle over 1 year ago

  • Tracker changed from Bug to Regression
Actions
Copy link
 #5

Updated by Jim Pingle over 1 year ago

  • Status changed from Pull Request Review to In Progress
  • Assignee changed from Christopher Cope to Jim Pingle
Actions
Copy link
 #6

Updated by Jim Pingle over 1 year ago

  • Status changed from In Progress to Feedback
  • % Done changed from 0 to 100
Actions
Copy link
 #7

Updated by Christopher Cope over 1 year ago

  • Status changed from Feedback to Resolved

Tested on

23.01-DEVELOPMENT (amd64)
built on Fri Nov 18 06:04:48 UTC 2022
FreeBSD 14.0-CURRENT

Working correctly now. Marking resolved.

Actions
Copy link

Also available in: Atom PDF