Project

General

Profile

Actions
Copy link

Regression #13661

closed

Feature #13446: Upgrade PHP from 7.4 to 8.1

Input validation issues on firewall_shaper.php

Added by Reid Linnemann over 1 year ago. Updated over 1 year ago.

Status:
Resolved
Priority:
Normal
Assignee:
Reid Linnemann
Category:
Traffic Shaper (ALTQ)
Target version:
2.7.0
Start date:
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
23.01
Release Notes:
Force Exclusion
Affected Version:
Affected Architecture:

Description

On the firewall_shaper.php page, when I create a new shaper without setting a bandwidth I see this error:

Fatal error: Uncaught TypeError: Unsupported operand types: string * int in /etc/inc/shaper.inc:762
Stack trace:
#0 /etc/inc/shaper.inc(809): altq_root_queue->CheckBandwidth('', 'Mb')
#1 /usr/local/www/firewall_shaper.php(219): altq_root_queue->validate_input(Array, Array)
#2 {main}
  thrown in /etc/inc/shaper.inc on line 762
PHP ERROR: Type: 1, File: /etc/inc/shaper.inc, Line: 762, Message: Uncaught TypeError: Unsupported operand types: string * int in /etc/inc/shaper.inc:762
Stack trace:
#0 /etc/inc/shaper.inc(809): altq_root_queue->CheckBandwidth('', 'Mb')
#1 /usr/local/www/firewall_shaper.php(219): altq_root_queue->validate_input(Array, Array)
#2 {main}
  thrown

Also, on the same page it is not possible to create one with CODELQ, as it both requires and disallows Qlimit in that case.

Actions
Copy link

Also available in: Atom PDF