pfSense

Do we have access to the config that triggered this? Somehow it would have to have either a completely empty tunnel entry or one that lacks any encryption options in P1 at all, which the GUI won't let you create.

According to a user on the forum thread, their pre-upgrade configuration contained the following section:

            <encryption>
                <item>
                    <encryption-algorithm>
                        <name>3des</name>
                        <keylen></keylen>
                    </encryption-algorithm>
                    <hash-algorithm>sha512</hash-algorithm>
                    <prf-algorithm>sha256</prf-algorithm>
                    <dhgroup>20</dhgroup>
                </item>
                <item>
                    <encryption-algorithm>
                        <name>3des</name>
                        <keylen></keylen>
                    </encryption-algorithm>
                    <hash-algorithm>sha256</hash-algorithm>
                    <prf-algorithm>sha256</prf-algorithm>
                    <dhgroup>20</dhgroup>
                </item>
            </encryption>

I applied the patch on:

23.01-RELEASE (amd64)
built on Fri Feb 10 20:06:33 UTC 2023
FreeBSD 14.0-CURRENT

However, after restoring the config with the empty <encryption></encryption> section, a PHP crush occurred in the GUI.

Crash report begins.  Anonymous machine information:

amd64
14.0-CURRENT
FreeBSD 14.0-CURRENT #0 plus-RELENG_23_01-n256037-6e914874a5e: Fri Feb 10 20:30:29 UTC 2023     root@freebsd:/var/jenkins/workspace/pfSense-Plus-snapshots-23_01-main/obj/amd64/VDZvZksF/var/jenkins/workspace/pfSense-Plus-snapshots-23_01-main/sources/FreeBS

Crash report details:

PHP Errors:
[04-Mar-2023 15:36:12 Etc/UTC] PHP Fatal error:  Uncaught TypeError: Cannot access offset of type string on string in /etc/inc/ipsec.inc:2546
Stack trace:
#0 /etc/inc/ipsec.inc(3267): ipsec_setup_tunnels(Array)
#1 /etc/rc.bootup(401): ipsec_configure()
#2 {main}
  thrown in /etc/inc/ipsec.inc on line 2546

No FreeBSD crash data found.

Yet, I could edit the IPsec in the GUI with no new crashes.