Regression #14091
closed
The "Kill States" button does not work consistently
100%
Description
Steps to reproduce
1)go to Dignostics=>States
2)Use the Filter expression field to filter using some known destination IP (8.8.8.8 for example)
3)Hit the "Filter" button
4)Hit the "Kill States" button
The "kill States" button will do nothing with filtered states, but if you use the Source IP in the filter it will kill the filtered states.
Updated by Jim Pingle over 1 year ago
- Project changed from pfSense Plus to pfSense
- Subject changed from The "Kill States" button not working if you filter by the destination IP address. to The "Kill States" button does not work consistently
- Category changed from Configuration Backend to Rules / NAT
- Status changed from New to Confirmed
- Target version set to 2.7.0
- Affected Plus Version deleted (
23.01) - Plus Target Version set to 23.05
It doesn't seem to be about the destination, it works sometimes and not others.
I tried a few different states and some I could kill and others I could not. But if I removed the utf8_encode() from around $tokill on both lines at source:src/usr/local/www/diag_dump_states.php#L58 then it did kill them.
That was added a while back to fix a different bug (#9270) but perhaps the underlying issue there changed.
Updated by Jim Pingle over 1 year ago
- Assignee deleted (
Jim Pingle)
Tried this again since some changes went into the module overnight. If I filter and try to kill a subnet style string such as x.x.x.x/32 the states are not removed, but the string in the filter field remains the same.
If I remove the utf8_encode() from the calls to pfSense_kill_states() and filter/kill for the subnet again, then the issues from #9270 comes back where the filter string in the GUI field gets an odd character, but the states are killed.
From what I can tell the problem here has to be somewhere in the module but it's not clear what it might be.
Updated by Christian McDonald over 1 year ago
- Assignee set to Christian McDonald
Updated by Christian McDonald over 1 year ago
I'll take this one. I'm quite familiar with the module after porting it to PHP8.
Updated by Christian McDonald over 1 year ago
- Status changed from Confirmed to Feedback
Okay I have fixes in the PHP module that properly fixes #9270, which was still a bug and likely related to this issue.
Updated by Jim Pingle over 1 year ago
- Status changed from Feedback to Resolved
- % Done changed from 0 to 100
Looks good on today's snapshot. I can kill states for a single address or a subnet. The states are actually removed and the value in the form field is not altered in either case.