pfSense

It doesn't seem to be about the destination, it works sometimes and not others.

I tried a few different states and some I could kill and others I could not. But if I removed the utf8_encode() from around $tokill on both lines at source:src/usr/local/www/diag_dump_states.php#L58 then it did kill them.

That was added a while back to fix a different bug (#9270) but perhaps the underlying issue there changed.

Tried this again since some changes went into the module overnight. If I filter and try to kill a subnet style string such as x.x.x.x/32 the states are not removed, but the string in the filter field remains the same.

If I remove the utf8_encode() from the calls to pfSense_kill_states() and filter/kill for the subnet again, then the issues from #9270 comes back where the filter string in the GUI field gets an odd character, but the states are killed.

From what I can tell the problem here has to be somewhere in the module but it's not clear what it might be.

Okay I have fixes in the PHP module that properly fixes #9270, which was still a bug and likely related to this issue.

Looks good on today's snapshot. I can kill states for a single address or a subnet. The states are actually removed and the value in the form field is not altered in either case.