Project

General

Profile

Actions

Bug #14275

closed

Deleting a route map that is assigned to an active neighbor causes crash

Added by M Felden about 1 year ago. Updated 11 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
FRR
Target version:
-
Start date:
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Affected Version:
2.7.0
Affected Plus Version:
Affected Architecture:

Description

Steps to reproduce:

2.7.0.a.20230405.0015 / FRR 7.5.1.

1) Establish BGP session to a neighbor and announce a prefix. IPv4/IPv6 doesn't matter.

2) Create a route map named "prepend" seq 100 with action

set as-path prepend 65530

3) Edit neighbor config to set the previously created route map "prepend" under "Outbound Route Map Filter"

4) We are now prepending 65530 to our announcement

5) Go back to Global Settings -> Route Maps pkg.php?xml=frr/frr_global_routemaps.xml and delete this active, in use route map.

6) Now try to edit the neighbor. The GUI will look OK insofar as it will show "Outbound Route Map Filter" "None" but if you try to save now, it will crash and service will stay down.

7) pkg_edit.php?xml=frr/frr_bgp.xml and pkg_edit.php?xml=frr/frr_global_raw.xml will also display this error text while pkg.php?xml=frr/frr_global_routemaps.xml and pkg.php?xml=frr/frr_bgp_neighbors.xml look normal

The only way to recover and get the service back up is to go back and redo step 2 with at least a blank route map named "prepend" with seq 100.

Expected Behavior: Going to pkg.php?xml=frr/frr_bgp_neighbors.xml and hitting save should apply and save what is shown on the GUI, i.e "Outbound Route Map Filer" is "None". It should produce a working config.

Actual Behavior: It expects the missing route map to be present and dies. There is a disconnect between what is shown in neighbor config GUI and what is happening in frr_generate_config_bgp


Files

Screenshot 2023-04-13 062628.png (184 KB) Screenshot 2023-04-13 062628.png M Felden, 04/13/2023 06:27 AM
crashreport.txt (3.55 KB) crashreport.txt M Felden, 04/13/2023 06:27 AM
Screenshot 2023-04-13 063209.png (121 KB) Screenshot 2023-04-13 063209.png M Felden, 04/13/2023 06:32 AM
Actions #1

Updated by Alhusein Zawi about 1 year ago

it shows an error if the route map was deleted..

the configuration shows the route map is not deleted while it was deleted but the service is still up.

it is better to restrict the deletion if the route map was assigned to neighbor's configuration .

Actions #2

Updated by Jim Pingle 11 months ago

  • Subject changed from FRR 7.5.1 on 2.7.0.a.20230405.0015 - deleting a route map that is assigned to an active neighbor causes crash to Deleting a route map that is assigned to an active neighbor causes crash
  • Status changed from New to Feedback
  • Assignee set to Jim Pingle
  • % Done changed from 0 to 100

This should be fixed in FRR Package v1.3, which is building now and will be available shortly.

Actions #3

Updated by Danilo Zrenjanin 11 months ago

  • Status changed from Feedback to Resolved

Tested against FRR Package v1.3.

It's fixed.

I am marking this ticket resolved.

Actions

Also available in: Atom PDF