Regression #14488
closed
Extensions directory is not set in ``rc.php_ini_setup``
100%
Description
rc.php_ini_setup not checking php version 8.2
--- /root/rc.php_ini_setup 2023-06-19 04:10:57.592644000 0000
++ /etc/rc.php_ini_setup 2023-06-19 04:10:32.037813000 +0000@ -24,7 +24,9 @
VERSION=$(/bin/cat /etc/version)
MIN_REALMEM_FOR_OPCACHE=512
-if /usr/local/sbin/pkg-static info -e php81; then
if /usr/local/sbin/pkg-static info -e php82; then
EXTENSIONSDIR="/usr/local/lib/php/20220829/"
+elif /usr/local/sbin/pkg-static info -e php81; then
EXTENSIONSDIR="/usr/local/lib/php/20210902/"
elif /usr/local/sbin/pkg-static info -e php74; then
EXTENSIONSDIR="/usr/local/lib/php/20190902/"
Updated by Marcello Silva Coutinho over 1 year ago
Updated by Jim Pingle over 1 year ago
I'm not sure we even need to set this anymore. It is using the correct directory already by default.
: php-config --extension-dir /usr/local/lib/php/20220829
Updated by Marcos M about 1 year ago
- Tracker changed from Bug to Regression
- Subject changed from rc.php_ini_setup not checking php version 8.2 to rc.php_ini_setup extensions directory is not set
- Status changed from New to Pull Request Review
- Assignee set to Marcos M
- Target version set to 2.8.0
- Plus Target Version set to 24.03
Looks like extension_dir defaults to the correct path when the value is empty. However, EXTENSIONSDIR is used when loading modules which are not "compiled into php statically"; I'm not sure if there's a case where that would happen normally, but the fix is simple enough to include.
Updated by Marcos M about 1 year ago
- Status changed from Pull Request Review to Feedback
Applied in changeset 132fef021c94f6823af72ff348e061ad5d3bb64c.
Updated by Jim Pingle 10 months ago
- Subject changed from rc.php_ini_setup extensions directory is not set to Extensions directory is not set in ``rc.php_ini_setup``
Updated by Jim Pingle 9 months ago
- Status changed from Feedback to New
The change here hardcoded checks for php81 and php82, but we are now on php83. Does this need another adjustment?
I'm not seeing EXTENSIONSDIR in php.ini on a current snapshot.
Updated by Jim Pingle 9 months ago
- Assignee changed from Marcos M to Jim Pingle
Yes, it does need a change for PHP 8.3. Commit pushed and should show up momentarily.
Updated by Jim Pingle 9 months ago
- Status changed from New to Feedback
- % Done changed from 0 to 100
Applied in changeset 903c1898973f3524e50ac44306838ccc6ed3558e.
Updated by Jim Pingle 9 months ago
- Status changed from Feedback to Resolved
It's present and working on the current snapshot.