Regression #14488: Extensions directory is not set in ``rc.php_ini_setup`` - pfSense - pfSense bugtracker

Custom queries

2.4.5-p1 - Resolved/Closed
2.5.0 - Resolved/Closed
2.5.1 - Resolved/Closed
2.5.2 - Resolved/Closed
2.6.0 - Resolved/Closed
2.7.0 - Resolved/Closed
2.7.1 - All Open Issues
2.7.1 - Resolved/Closed
2.7.2 - Resolved/Closed
2.8.0 - All Open Bugs
2.8.0 - All Open Features
2.8.0 - All Open Issues
2.8.0 - All Open Regressions
2.8.0 - Feedback
2.8.0 - Needs Attention
2.8.0 - New/Confirmed
2.8.0 - Pull Requests
2.8.0 - Regressions affecting 2.7.0
2.8.0 - Resolved/Closed
21.02.2/2.5.1 - Resolved/Closed
21.05 Plus - All Closed Issues
21.05.1 Plus Target - All Closed Issues
21.05.1 Target - All Closed Issues
22.01 Plus - All Closed Issues
22.01 Target - All Closed Issues
22.05 Plus - All Closed Issues
22.05 Target - All Closed Issues
23.01 Plus - All Closed Issues
23.01 Target - All Closed Issues
23.05 Plus - All Closed Issues
23.05 Target - All Closed Issues
23.05.1 Plus - All Closed Issues
23.05.1 Target - All Closed Issues
23.09 Plus - All Closed Issues
23.09 Target - All Closed Issues
23.09.1 Plus - All Closed Issues
23.09.1 Target - All Closed Issues
24.03 Plus - All Closed Issues
24.03 Target - All Closed Issues
24.07 Plus - All Closed Issues
24.07 Plus - All Open Issues
24.07 Plus - Feedback Issues
24.07 Plus - Needs Attention/Work
24.07 Plus - New/Confirmed/In Progress Issues
24.07 Plus - Pull Request Review
24.07 Plus - Waiting on Merge
24.07 Target - All Closed Issues
24.07 Target - All Open Issues
All Open Issues assigned to Me
All Open Pull Requests
Any Target - All Open Regressions
Any Target - Feedback Issues
CE-Next - All Closed Issues (Move to specific target)
CE-Next - All Open Issues
CE-Next - Feedback (Likely needs target changed)
New Issues by Category - Future Target
New Issues by Category - No Target
New Issues by Category - No Target+Future
No Target - All Open Issues (Base Only)
No Target - New Issues (Base Only)
No Target - New Issues (Base and Packages)
Release Notes - Plus Target Version (DO NOT EDIT)
Release Notes - Target Version (DO NOT EDIT)

Actions

Copy link

Regression #14488

closed

Extensions directory is not set in ``rc.php_ini_setup``

Added by Marcello Silva Coutinho 11 months ago. Updated 2 months ago.

Status:

Resolved

Priority:

Normal

Assignee:

Jim Pingle

Category:

PHP Interpreter

Target version:

2.8.0

Start date:

Due date:

% Done:

100%

Estimated time:

Plus Target Version:

24.03

Release Notes:

Default

Affected Version:

2.7.0

Affected Architecture:

Description

rc.php_ini_setup not checking php version 8.2

--- /root/rc.php_ini_setup 2023-06-19 04:10:57.592644000 0000
++ /etc/rc.php_ini_setup 2023-06-19 04:10:32.037813000 +0000
@ -24,7 +24,9 @
VERSION=$(/bin/cat /etc/version)
MIN_REALMEM_FOR_OPCACHE=512

-if /usr/local/sbin/pkg-static info -e php81; then
if /usr/local/sbin/pkg-static info -e php82; then
EXTENSIONSDIR="/usr/local/lib/php/20220829/"
+elif /usr/local/sbin/pkg-static info -e php81; then
EXTENSIONSDIR="/usr/local/lib/php/20210902/"
elif /usr/local/sbin/pkg-static info -e php74; then
EXTENSIONSDIR="/usr/local/lib/php/20190902/"

History
Notes
Property changes
Associated revisions

Actions

Copy link

Updated by Marcello Silva Coutinho 11 months ago

https://github.com/pfsense/pfsense/pull/4642

Actions

Copy link

Updated by Jim Pingle 11 months ago

I'm not sure we even need to set this anymore. It is using the correct directory already by default.

: php-config --extension-dir
/usr/local/lib/php/20220829

Actions

Copy link

Updated by Marcos M 6 months ago

Tracker changed from Bug to Regression
Subject changed from rc.php_ini_setup not checking php version 8.2 to rc.php_ini_setup extensions directory is not set
Status changed from New to Pull Request Review
Assignee set to Marcos M
Target version set to 2.8.0
Plus Target Version set to 24.03

Looks like extension_dir defaults to the correct path when the value is empty. However, EXTENSIONSDIR is used when loading modules which are not "compiled into php statically"; I'm not sure if there's a case where that would happen normally, but the fix is simple enough to include.

Actions

Copy link