Project

General

Profile

Actions

Bug #14996

open

KEA DHCP PHP error

Added by Danilo Zrenjanin 3 months ago. Updated 10 days ago.

Status:
New
Priority:
Normal
Category:
DHCP (IPv4)
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
24.03
Release Notes:
Default
Affected Version:
Affected Architecture:

Description

PHP ERROR: Type: 1, File: /etc/inc/services.inc, Line: 1411, Message: Uncaught TypeError: implode(): Argument #1 ($array) must be of type array, string given in /etc/inc/services.inc:1411
Stack trace:
#0 /etc/inc/services.inc(1411): implode(', ', NULL)
#1 /etc/inc/services.inc(1006): services_kea4_configure()
#2 /usr/local/pfSense/include/www/system_advanced_network.inc(258): services_dhcpd_configure()
#3 /usr/local/www/system_advanced_network.php(47): saveAdvancedNetworking(Array)
#4 {main}
thrown @ 2023-11-16 13:18:52

Steps to reproduce:
1.) Make sure that the ISC DHCP (Deprecated) Backend server is selected under System/Advanced/Networking
2.) Go to Services/DHCP Server/LAN.
3.) Click on the Add Address Pool button.
4.) Define a new Address Pool Range and at least one WINS server. Save the pool settings.
5.) Go back to the System/Advanced/Networking and select Kea DHCP then save the changes.

You'll get the same PHP error if you directly define an additional pool in KEA DHCP and enter a WINS server there.

Actions #1

Updated by Jim Pingle 3 months ago

  • Target version set to 2.8.0
  • Plus Target Version set to 24.03
Actions #2

Updated by Jared Hendrickson about 1 month ago

I opened a PR this morning that contains a fix for this: https://github.com/pfsense/pfsense/pull/4667

Actions #3

Updated by Kris Phillips about 1 month ago

Jared Hendrickson wrote in #note-2:

I opened a PR this morning that contains a fix for this: https://github.com/pfsense/pfsense/pull/4667

Tested this fix on 23.09.1. PHP error is no longer present after the patch is applied.

Thank you for this PR!

Actions #4

Updated by Kris Phillips 10 days ago

Kris Phillips wrote in #note-3:

Jared Hendrickson wrote in #note-2:

I opened a PR this morning that contains a fix for this: https://github.com/pfsense/pfsense/pull/4667

Tested this fix on 23.09.1. PHP error is no longer present after the patch is applied.

Thank you for this PR!

Can we get this PM reviewed and integrated into CE and Plus for the next release? This seems like a simple typo and should be easy to merge.

Actions #5

Updated by Christian McDonald 10 days ago

  • Assignee set to Christian McDonald

Yep. I'll do it on Monday

Actions

Also available in: Atom PDF