pfSense

There was some change here recently as now this triggers a failure on upgrade for existing mirrors.

The second disk has an EFI partition but it is unformatted, thus the pfSense-boot post-install script can't mount it using msdosfs since it doesn't yet have a filesystem:

# pkg upgrade -f pfSense-boot-2.8.0.a.20240101.0600
[...]
Updating EFI loader in ESP vtbd0p1
install: //boot/loader.efi -> //boot/efi/efi/freebsd/loader.efi
install: //boot/loader.efi -> //boot/efi/efi/boot/BOOTx64.efi
mount_msdosfs: /dev/vtbd1p1: Invalid argument
Couldn't mount //dev/vtbd1p1 to //boot/efi
pkg: POST-INSTALL script failed

If I manually format the partition on the second disk first, then re-run the upgrade, it works:

# newfs_msdos -F 32 -c 1 -L EFISYS1 /dev/gpt/efiboot1
# pkg upgrade -f pfSense-boot-2.8.0.a.20240101.0600
[...]

Updating EFI loader in ESP vtbd0p1
install: //boot/loader.efi -> //boot/efi/efi/freebsd/loader.efi
install: //boot/loader.efi -> //boot/efi/efi/boot/BOOTx64.efi
Updating EFI loader in ESP vtbd1p1
install: //boot/loader.efi -> //boot/efi/efi/freebsd/loader.efi
install: //boot/loader.efi -> //boot/efi/efi/boot/BOOTx64.efi

Assigning to Reid since he's been working on this area.

This should work with the new `install-boot` stage in pfSense-upgrade.

Christian McDonald wrote in #note-8:

This should work with the new `install-boot` stage in pfSense-upgrade.

I haven't checked it in a while, but I'm not seeing it update the EFI loader anywhere now, is there something else that should be triggering it?

: mount -t msdosfs /dev/gpt/efiboot1 /mnt
: find / -name loader.efi -exec ls -l {} \;
-rwxr-xr-x  1 root wheel 657920 Mar 15 13:17 /mnt/efi/freebsd/loader.efi
-r-xr-xr-x  2 root wheel 657408 Sep  6 04:25 /boot/loader.efi
-rwxr-xr-x  1 root wheel 657920 Mar 15 13:17 /boot/efi/efi/freebsd/loader.efi

Even if I manually reinstall pfSense-boot it doesn't change, nor does it change during a snapshot upgrade.

This is on a CE 2.8.0 snap.

Both disks have the same loader, but it's not the same as the one in /boot which has the date of the current snapshot.

Not seeing that issue from my last comment anymore.

This also appears to be OK in general. I installed an old version, confirmed it didn't have a good copy of EFI on the second disk, then upgraded it to 24.08 and afterward the EFI partition on the second disk contained the expected files.