Project

General

Profile

Actions
Copy link

Bug #15117

closed

Shortcut bar on DHCPv6 leases (``status_dhcpv6_leases.php``) navigates to DHCPv4 destinations, not DHCPv6

Added by David Cornejo 11 months ago. Updated 10 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Jim Pingle
Category:
DHCP (IPv6)
Target version:
2.8.0
Start date:
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
24.03
Release Notes:
Default
Affected Version:
Affected Architecture:

Description

The link to the DHCPv6 settings on the status page takes you to the settings for DHCP (v4)

Actions
Copy link
 #1

Updated by Danilo Zrenjanin 11 months ago

  • Status changed from New to Confirmed

I can confirm this behavior on:

23.09.1-RELEASE (amd64)
built on Wed Dec 20 18:27:00 UTC 2023
FreeBSD 14.0-CURRENT
Actions
Copy link
 #2

Updated by Kris Phillips 11 months ago

I'm not able to confirm this. Going to Status --> DHCPv6 Leases --> Related Settings link at the top goes to the DHCPv6 Server configuration on my 23.09.1 appliance.

Is there another settings link that I'm missing here? What is the exact path?

Actions
Copy link
 #3

Updated by David Cornejo 11 months ago

It is, indeed, the related settings link. on my system, this is a link to
https://<fqdn>/services_dhcp.php - it should be https://<fqdn>/services_dhcpv6.php

Also, the Related Status link points at https://<fqdn>/status_dhcp_leases.php - i guess dhcp v4 is related, but it is not clear what was intended there. In status_dhcp_leases.php, the related status link points back to itself, so I think that the related status of the v6 page should be consistent and point back to itself.

An argument could be made that a link pointing back to the page containing it is not very useful and should be removed, which might be easier.

this seems to be generated by the function get_shortcut_main_link() in shortcuts.inc

I am running the same version as Danilo confirmed with.

Actions
Copy link
 #4

Updated by Jim Pingle 11 months ago

  • Project changed from pfSense Plus to pfSense
  • Subject changed from bad link to settings on StatusDHCPv6 Leases page to Settings icon in shortcut bar on DHCPv6 leases (``status_dhcpv6_leases.php``) links to ``services_dhcp.php`` instead of ``services_dhcpv6.php``
  • Category changed from Web Interface to DHCP (IPv6)
  • Target version set to 2.8.0
  • Affected Plus Version deleted (23.09.1)
  • Plus Target Version set to 24.03

It's incorrect for me as well, the shortcut section on the page is set to dhcp when it should be dhcp6:

source:src/usr/local/www/status_dhcpv6_leases.php#L42

Actions
Copy link
 #5

Updated by Jim Pingle 11 months ago

  • Assignee set to Jim Pingle
Actions
Copy link
 #6

Updated by Jim Pingle 11 months ago

  • Status changed from Confirmed to Feedback
  • % Done changed from 0 to 100
Actions
Copy link
 #7

Updated by Danilo Zrenjanin 11 months ago

  • Status changed from Feedback to Resolved

The patch fixes it.

I am marking this ticket as resolved.

Actions
Copy link
 #8

Updated by Jim Pingle 11 months ago

  • Subject changed from Settings icon in shortcut bar on DHCPv6 leases (``status_dhcpv6_leases.php``) links to ``services_dhcp.php`` instead of ``services_dhcpv6.php`` to Shortcut bar on DHCPv6 leases (``status_dhcpv6_leases.php``) navigate to DHCPv4 destinations, not DHCPv6

Rewording subject for the release notes since this affected everything on the shortcut bar on that page, not just the settings link.

Actions
Copy link
 #9

Updated by Jim Pingle 10 months ago

  • Subject changed from Shortcut bar on DHCPv6 leases (``status_dhcpv6_leases.php``) navigate to DHCPv4 destinations, not DHCPv6 to Shortcut bar on DHCPv6 leases (``status_dhcpv6_leases.php``) navigates to DHCPv4 destinations, not DHCPv6
Actions
Copy link

Also available in: Atom PDF