Project

General

Profile

Actions

Bug #15181

closed
JB KP

PHP error in ``interfaces_qinq_edit.php`` when creating a QinQ interface

Bug #15181: PHP error in ``interfaces_qinq_edit.php`` when creating a QinQ interface

Added by Jens Becker over 2 years ago. Updated over 2 years ago.

Status:
Resolved
Priority:
Normal
Category:
Interfaces
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
24.03
Release Notes:
Default
Affected Version:
2.7.2
Affected Architecture:
All

Description

When creating a new QinQ interface on /interfaces_qinq_edit.php it throws this error:

[21-Jan-2024 22:59:34 Europe/Berlin] PHP Fatal error:  Uncaught TypeError: Cannot access offset of type string on string in /usr/local/www/interfaces_qinq_edit.php:206
Stack trace:
#0 {main}
  thrown in /usr/local/www/interfaces_qinq_edit.php on line 206

After this the Interfaces QinQs view is still empty but the new interfaces show up on Interface Assignments. After a reboot they are gone again.

This to me looks similar to #9109

DM Updated by dylan mendez over 2 years ago Actions #1

Created two QinQ interfaces on two different interfaces, no issue. 23.09.1

Can you please share your pfSense version as well as specific VLAN IDs you're using?

JB Updated by Jens Becker over 2 years ago Actions #2

dylan mendez wrote in #note-1:

Can you please share your pfSense version as well as specific VLAN IDs you're using?

Yes, thank you.
The version I'm using is 2.7.2 (CE).
I found out that when I create QinQ without checking "Adds interface to QinQ interface groups" it works without a problem - so the issue seems to be creating the Interface Group and not the QinQ itself.
This happens with every VLAN ID I have tried, for example 9 or 23.
Maybe there is a configuration file I can look at and/or post for more information?

DM Updated by dylan mendez over 2 years ago Actions #3

Tested in 2.7.0, 2.7.2 and 23.09.
I'm able to create QinQ interfaces without any issue. Both with and without the interface group checkmark.

DM Updated by dylan mendez over 2 years ago Actions #4

Does your NIC support QinQ?

DM Updated by dylan mendez over 2 years ago Actions #5

Also, do you have any existing Interface Groups?

MM Updated by Marcos M over 2 years ago Actions #6

  • Status changed from New to Feedback
  • Assignee set to Kristof Provost
  • Target version set to 2.8.0
  • % Done changed from 0 to 100
  • Plus Target Version set to 24.03

Fixed in commit:600f240e48091fe3ee4ba83d6fc4c93892669329.

JP Updated by Jim Pingle over 2 years ago Actions #7

  • Subject changed from interfaces_qinq_edit.php: PHP error when trying to create QinQ interface to PHP error in ``interfaces_qinq_edit.php`` when creating a QinQ interface

DZ Updated by Danilo Zrenjanin over 2 years ago Actions #8

I couldn't replicate this either.

@Jens Becker
Can you apply the patch and see if it fixes that in your environment?

https://docs.netgate.com/pfsense/en/latest/development/system-patches.html#adding-a-custom-patch

JB Updated by Jens Becker over 2 years ago Actions #9

Danilo Zrenjanin wrote in #note-8:

Can you apply the patch and see if it fixes that in your environment?

I can confirm that this patch fixes the issue for me. Thanks!

DZ Updated by Danilo Zrenjanin over 2 years ago Actions #10

  • Status changed from Feedback to Resolved

Thank you for confirming, Jens!

I am closing this ticket as resolved.

Actions

Also available in: Atom