Bug #15729
closed
- Status changed from Ready To Test to Feedback
- % Done changed from 0 to 100
- Status changed from Feedback to Confirmed
Tested on
24.11-ALPHA (amd64)
built on Fri Oct 11 19:54:00 UTC 2024
FreeBSD 15.0-CURRENT
Several of the errors are no longer present, but it seems there are still some that aren't fixed, such as:
Cookie “treegrid-disks-0” does not have a proper “SameSite” attribute value. Soon, cookies without the “SameSite” attribute or with an invalid value will be treated as “Lax”. This means that the cookie will no longer be sent in third-party contexts. If your application depends on this cookie being available in such contexts, please add the “SameSite=None“ attribute to it. To know more about the “SameSite“ attribute, read https://developer.mozilla.org/docs/Web/HTTP/Headers/Set-Cookie/SameSite
disks.widget.php has some additional cookie code that is causing the warning.
Since the cookies seem to be handled in auth.inc, I deleted some code from disks widget.
The warning has disappeared and the cookies look OK.
PR:
https://github.com/pfsense/pfsense/pull/4705
- Subject changed from Add samesite attribute to session cookies to Address dashboard session cookie warnings
- Status changed from Confirmed to Resolved
- Target version set to 2.8.0
- Plus Target Version set to 24.11
The treegrid cookies for the Disk and ZFS widgets have been removed. With the widget-specific cookies removed, treegrid keeps the collapse state between both page reloads and widget refreshes.
- Tracker changed from Todo to Bug
- Subject changed from Address dashboard session cookie warnings to Session cookie warnings
- Category changed from Web Interface to Dashboard
Also available in: Atom
PDF