Bug #16076
closed
Deleting or adding a firewall rule may result in an unexpected rule order
100%
Description
There seems to be an issue with firewall rules being re-ordered after using the red (multiple) "Delete" button, even when only a single firewall rule was deleted with it.
- 1.png = 1,2,3,4,5,6,7,8,9,10
- 2.png = (* is rules selected) 1,2*,3,4,5,6,7*,8,9,10
- 3.png = (after delete) 8,9,10,1,2,3,4,5,6
- 4.png = 3 is deleted using the delete button on the rule line itself (rule order doesn't change)
- 5.png = (* is rules selected) 8,9*,10,1,2,4*,5,6
- 6.png = (after delete) 10,1,2,5,6,8
- 7.png = (* is rules selected) 10*,1,2,5,6,8*
- 8.png = (after delete) 1,2,5,6
- 9.png = (* is a single rule selected) 1,2*,5,6
- 10.png = (after delete) 5,6,1
Files
Updated by Craig . about 2 months ago
Sorry, 2.png should = 1,2,3,4,5,6,7*,8,9,10
Updated by Marcos M about 2 months ago
- Project changed from pfSense Plus to pfSense
- Subject changed from Rule order is changing after using the 'multiple delete' button to Deleting a firewall rule may result in an unexpected rule order
- Category changed from Rules / NAT to Rules / NAT
- Status changed from New to In Progress
- Assignee set to Marcos M
- Target version set to 2.8.0
- Affected Plus Version deleted (
24.11) - Plus Target Version set to 25.03
Updated by Marcos M about 2 months ago
- Status changed from In Progress to Feedback
- % Done changed from 0 to 100
This regressed after the fix for https://redmine.pfsense.org/issues/15935 which added the call to filter_rules_sort() which exposed the reported issue.
This should be fixed with c181ebe180017116626da28f30407a1da3cba061.
Note that the issue only applies when MIM is not running/disabled.
Updated by Marcos M about 1 month ago
- Subject changed from Deleting a firewall rule may result in an unexpected rule order to Deleting or adding a firewall rule may result in an unexpected rule order
- Set up 4 rules on each interface - Ethernet, Floating, WAN, and LAN - with a separator between rule 2 and 4.
- On LAN, add a rule using the up-arrow Add button; save but don't apply changes.
- This clobbers the Ethernet/Floating rules order and index (see
idin the URL for each rule).
- This clobbers the Ethernet/Floating rules order and index (see
This issue is fixed with 6664dd6d2268c91f48a71b565201fa52e3e3db97
The fixes have been added to the System Patches package for 24.11.
Updated by Marcos M about 1 month ago
- Status changed from Resolved to Feedback
A fix has been committed for an issue with Ethernet rules (details on the forum).
Updated by Jordan G about 1 month ago
with above patch applied (on 24.11) and MIM disabled, deleting multiple firewall rules by selecting desired rules and using the delete button does not appear to have any adverse effect on the existing order of the remaining rules.