Project

General

Profile

Actions

Feature #1997

closed

Add date picker to the Custom RRD graph page to translate to unix time.

Added by Seth Mos about 10 years ago. Updated over 9 years ago.

Status:
Resolved
Priority:
Low
Assignee:
Category:
RRD Graphs
Target version:
Start date:
11/08/2011
Due date:
% Done:

90%

Estimated time:
2.00 h
Plus Target Version:
Release Notes:

Description

The current custom rrd graph page needs a startdate and enddate in unix time. This really needs a date picker that sets the unix time to be intuitive and easy to use.

Actions #2

Updated by Simon Fong about 10 years ago

That is an EXCELLENT converter, probably the BEST and ONLY one which allows for free-form (eg. 11/9/2011 12:15:59) input of time string, and can also take into account for both UTC and/or GMT timezones. All others requires separate fields for input and only has code for UTC times.

Actions #3

Updated by Chris Buechler over 9 years ago

  • Tracker changed from Bug to Feature
  • Status changed from New to Assigned
  • Assignee set to Darren Embry
  • Affected Version deleted (2.1-IPv6)
Actions #4

Updated by Darren Embry over 9 years ago

  • Status changed from Assigned to Resolved
  • % Done changed from 0 to 100

Input fields are now freeform. I went with PHP's strtotime() function for freeform input. It understands time zones and everything.

https://github.com/bsdperimeter/pfsense/commit/59418ceef6ffa89a9da38f4d4a1251dc73d5c05f

Actions #5

Updated by Jim Pingle over 9 years ago

Would still be nice to have a JS Date Picker in the GUI end so people don't have to type it out. Clicking around a calendar is a lot easier. :-)

Actions #6

Updated by Darren Embry over 9 years ago

Okay we have a datepicker now:
https://github.com/bsdperimeter/pfsense/commit/ce49a7c9f2781bda704e4e561026b5e445ab1fcb
Hope the jQuery UI theme I selected matches pfSense closely enough. :-)

Actions #7

Updated by Darren Embry over 9 years ago

  • Status changed from Resolved to Feedback
  • % Done changed from 100 to 90
Actions #8

Updated by Simon Fong over 9 years ago

I hope the date picker will have the ability to accurately "pick" hours, minutes, and seconds rather than rounding to nearest hour/minute or so.

Also I like how some apps on smartphones/tablets allows for BOTH freeform/keyboard AND calendar/GUI picking.

Just curious, during Daylight Savings Time Change, does pfSense's RRD graphs discard or keeps, the added OR subtracted hour of data?

Actions #9

Updated by Darren Embry over 9 years ago

I can't speak for daylight saving time handling but the rest of your needs are fit by this.

http://trentrichardson.com/examples/timepicker/

See that for a demo. It's pretty customizable.

Actions #10

Updated by Chris Buechler over 9 years ago

  • Status changed from Feedback to Resolved

this is fixed, looks good.

Simon - this isn't the place for OT questions, please post to the forum or list.

Actions

Also available in: Atom PDF