Project

General

Profile

Actions
Copy link

Bug #2415

closed

Fallout from CARP vip interface names changes

Added by Jim Pingle over 12 years ago. Updated over 12 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Seth Mos
Category:
CARP
Target version:
2.1
Start date:
05/08/2012
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
Affected Architecture:

Description

Now that CARP VIP interfaces have been renamed, some issues have come up. They are now named, for example, wan_vip241.

  • They appear in the list for assignment under Interfaces > (assign).
  • Some code still looks for "vip" such as the static route check for IPsec in vpn.inc
  • More?

Since these changes were also committed on RELENG_2_0 any fixes need to be cherry-picked.

Possible things that need fixed:

etc/inc/filter.inc:                     if(preg_match("/^vip/i", $ph1ent['interface'])) {
etc/inc/interfaces.inc:         if (preg_match("/^vip|^tun|^ovpn|^gif|^gre|^lagg|^bridge|vlan|^stf|^srd/i", $realif))
etc/inc/interfaces.inc:         else if (preg_match("/^vip/i", $interface))
etc/inc/interfaces.inc:         else if (preg_match("/^vip/i", $interface))
etc/inc/interfaces.inc:         else if (preg_match("/^vip/i", $interface))
etc/inc/interfaces.inc:                else if (preg_match("/^vip/i", $interface))
etc/inc/interfaces.inc:                else if (preg_match("/^vip/i", $interface))
etc/inc/vpn.inc:                                if (preg_match("/^carp|^vip/i", $ph1ent['interface']))

The matches for "^vip" will no longer match.

Actions
Copy link
 #1

Updated by Seth Mos over 12 years ago

  • Assignee set to Seth Mos
Actions
Copy link
 #2

Updated by Chris Buechler over 12 years ago

this needs to be backed out entirely from RELENG_2_0, it wasn't supposed to be there.

Actions
Copy link
 #3

Updated by Jim Pingle over 12 years ago

I reverted that commit, had to adjust a few things since it didn't come out cleanly, but it should be out of RELENG_2_0 now.

Actions
Copy link
 #4

Updated by Seth Mos over 12 years ago

  • Status changed from New to Feedback

Changes have been committed but I still see Carp vips showing up in different places.

E.g. Add a carp vip on the virtual IP page. It will then list the newly created carp vip as a selectable interface from the drop down. Not sure if that was supposed to be there.

Actions
Copy link
 #5

Updated by Jim Pingle over 12 years ago

It's supposed to be selectable there for IP Alias type VIPs, so they can ride on top of the carp interface. (As a means to get multiple IPs on a single vhid to overcome the limit on VHIDs)

Actions
Copy link
 #6

Updated by Jim Pingle over 12 years ago

  • Status changed from Feedback to Resolved
Actions
Copy link

Also available in: Atom PDF