Bug #3117
closed
Services: Dynamic DNS client: leading and trailing spaces in hostname field breaks the DDNS functionality
100%
Description
I just added another DDNS provider and was wondering about the error message in the system log:
php: /services_dyndns_edit.php: phpDynDNS: (Error) Hostname supplied does not exist.
Again I looked into the "Dynamic DNS client" dialog and could not see any mistakes. So I clicked again into the hostname field and found, uups, a leading space. Bingo!
So here is my request: Please trim hostname fields so all leading and trailing whitespaces will be removed automatically.
Kind regards,
routerfreak
Updated by Phillip Davis over 11 years ago
There could be a general change to automatically trim all GUI input fields where it is invalid to have white space at the beginning or end of the string. That would be a bit of work to go through the whole system and decide which things to trim on input.
Updated by Renato Botelho over 11 years ago
- Status changed from New to Feedback
- % Done changed from 0 to 100
Applied in changeset 1be999112daa9aba26e4ce10f7d7da06b9244e5d.
Updated by Renato Botelho over 11 years ago
Applied in changeset 7f3ad605133812ff7ff6cae8b7b00ac1a08012ba.
Updated by Renato Botelho over 11 years ago
Phillip Davis wrote:
There could be a general change to automatically trim all GUI input fields where it is invalid to have white space at the beginning or end of the string. That would be a bit of work to go through the whole system and decide which things to trim on input.
This can be useful for other places but it's not enough here, we need to make sure it's a valid domain name.
Updated by Renato Botelho over 11 years ago
Applied in changeset 6eeb0b2cc31f4e0c1cead2b616bf93eaba984a4c.
Updated by Chris Buechler over 11 years ago
- Status changed from Feedback to Resolved