portal_reply_page called twice in specific circumstance
If using vouchers and passthrough MAC addition with concurrent logins disabled, if a voucher code is reused, portal_allow() calls portal_reply_page() with "already authenticated using another MAC address." portal_allow() then returns and index.php calls portal_reply_page() again with "error" resulting in the reply page being displayed twice.
#1 Updated by Chris Linstruth about 6 years ago
Candidate patch here:
#7 Updated by A FL over 1 year ago
The bug reported by Constantine happens when "Add MAC addresses as pass-through" is checked but "include username in created MAC" is not
This is an issue related to a confusion between these two captiveportal settings
If "include username in created MAC" is unchecked then the username linked to the pass-through is still saved as description but not saved in captiveportal config, meaning pfSense cannot compare this MAC to an username later.
This issue is not linked to the recent changes, but it is still a bug.
I would suggest to automatically include username in the created pass-through, both in the description and in config