Project

General

Profile

Actions
Copy link

Bug #3124

closed
CL RB

portal_reply_page called twice in specific circumstance

Bug #3124: portal_reply_page called twice in specific circumstance

Added by Chris Linstruth about 13 years ago. Updated about 8 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Renato Botelho
Category:
Captive Portal
Target version:
2.4.4
Start date:
08/01/2013
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
Affected Architecture:

Description

If using vouchers and passthrough MAC addition with concurrent logins disabled, if a voucher code is reused, portal_allow() calls portal_reply_page() with "already authenticated using another MAC address." portal_allow() then returns and index.php calls portal_reply_page() again with "error" resulting in the reply page being displayed twice.

RB Updated by Renato Botelho about 8 years ago Actions
Copy link
 #2

  • Status changed from New to In Progress
  • Assignee set to Renato Botelho
  • Target version set to 2.4.4

RB Updated by Renato Botelho about 8 years ago Actions
Copy link
 #3

  • Status changed from In Progress to Feedback
  • % Done changed from 0 to 100

CK Updated by Constantine Kormashev about 8 years ago Actions
Copy link
 #4

I do not see the issue with doubling message, but see 2 different MACs which use the same voucher

192.168.1.11     00:50:56:a3:6d:3b     6pd4A877Eak     08/21/2018 06:19:57     
192.168.1.10     00:0c:29:fd:e7:98     6pd4A877Eak     08/21/2018 06:20:37

AF Updated by A FL about 8 years ago Actions
Copy link
 #5

Constantine Kormashev wrote:

I do not see the issue with doubling message, but see 2 different MACs which use the same voucher

That isn't normal
I'll investigate this. Thanks for reporting it

JP Updated by Jim Pingle about 8 years ago Actions
Copy link
 #6

  • Status changed from Feedback to 13

AF Updated by A FL about 8 years ago Actions
Copy link
 #7

The bug reported by Constantine happens when "Add MAC addresses as pass-through" is checked but "include username in created MAC" is not

This is an issue related to a confusion between these two captiveportal settings
If "include username in created MAC" is unchecked then the username linked to the pass-through is still saved as description but not saved in captiveportal config, meaning pfSense cannot compare this MAC to an username later.
This issue is not linked to the recent changes, but it is still a bug.

I would suggest to automatically include username in the created pass-through, both in the description and in config

RB Updated by Renato Botelho about 8 years ago Actions
Copy link
 #8

  • Status changed from 13 to Feedback

PR merged

AF Updated by A FL about 8 years ago Actions
Copy link
 #9

Working fine for me with vouchers & with Authentication Server

This issue can be marked as resolved !

JP Updated by Jim Pingle about 8 years ago Actions
Copy link
 #10

  • Status changed from Feedback to Resolved
Actions
Copy link

Also available in: Atom