Bug #3124
closed
portal_reply_page called twice in specific circumstance
100%
Description
If using vouchers and passthrough MAC addition with concurrent logins disabled, if a voucher code is reused, portal_allow() calls portal_reply_page() with "already authenticated using another MAC address." portal_allow() then returns and index.php calls portal_reply_page() again with "error" resulting in the reply page being displayed twice.
Updated by Chris Linstruth over 10 years ago
Candidate patch here:
https://github.com/derelict-pf/pfsense/commit/4fd56afe541a0a350dfe52b20521a551edd9f276
Updated by Renato Botelho over 5 years ago
- Status changed from New to In Progress
- Assignee set to Renato Botelho
- Target version set to 2.4.4
Updated by Renato Botelho over 5 years ago
- Status changed from In Progress to Feedback
- % Done changed from 0 to 100
PR https://github.com/pfsense/pfsense/pull/3972 has been merged.
Updated by Constantine Kormashev over 5 years ago
I do not see the issue with doubling message, but see 2 different MACs which use the same voucher
192.168.1.11 00:50:56:a3:6d:3b 6pd4A877Eak 08/21/2018 06:19:57 192.168.1.10 00:0c:29:fd:e7:98 6pd4A877Eak 08/21/2018 06:20:37
Updated by A FL over 5 years ago
Constantine Kormashev wrote:
I do not see the issue with doubling message, but see 2 different MACs which use the same voucher
That isn't normal
I'll investigate this. Thanks for reporting it
Updated by A FL over 5 years ago
The bug reported by Constantine happens when "Add MAC addresses as pass-through" is checked but "include username in created MAC" is not
This is an issue related to a confusion between these two captiveportal settings
If "include username in created MAC" is unchecked then the username linked to the pass-through is still saved as description but not saved in captiveportal config, meaning pfSense cannot compare this MAC to an username later.
This issue is not linked to the recent changes, but it is still a bug.
I would suggest to automatically include username in the created pass-through, both in the description and in config
Updated by A FL over 5 years ago
Working fine for me with vouchers & with Authentication Server
This issue can be marked as resolved !
Updated by Jim Pingle over 5 years ago
- Status changed from Feedback to Resolved