Bug #3376
closed
Alias Edit does not display correctly
100%
Description
I had a 2.1-RELEASE system and GitSync'd to the 2.1 release branch. I was using Alias Bulk Import, but then also realised this problem is with displaying any Network Alias in firewall_aliases_edit.php
I added a test bulk alias, as in screen shot 1
After saving, the alias looks OK in screen shot 2.
But when I try to edit it (screen shot 3) the CIDR shows as 32 for all the entries.
If I edit and then save, all those entries also get saved as "/32".
If I edit and save any of my network aliases they become "/32" unless I manually change them to the required values again before saving.
When editing a URL Table alias, the Update Freq column is left blank (and the config actually has a number of days).
Using any version of firewall_aliases_edit.php after commit https://github.com/pfsense/pfsense/commit/53523624259f97fb7148d80ae581fa09291e0c55 has this problem. Any version prior to that is OK. Something in the new code there that does jQuery stuff has a problem setting/enabling the CIDR/Update Freq column.
Files
Updated by Phillip Davis almost 11 years ago
I have no idea what I am doing with the jQuery stuff, but I pulled out some "^" marks in pull request https://github.com/pfsense/pfsense/pull/867 and now the display is correct. Someone who knows what the "^" were intended to do should look at it and decide what is the real/correct/best fix.
Updated by Phillip Davis almost 11 years ago
- Status changed from New to Feedback
- % Done changed from 0 to 100
Applied in changeset 1b9ab14ad23e1f66a11801fbe7a24423ab8529a0.
Updated by Phillip Davis almost 11 years ago
Applied in changeset 44b72c67ec3331ecd3a6430697ad47dbeac7c450.
Updated by Grischa Zengel almost 11 years ago
With this patch the subnet field won't be disabled like before.
The form uses <select name="address_subnet0" class="ipv4v6" id="address_subnet0" size="1"> with numbered ids.
jQuery("select[id^='address_subnet']") will match "address_subnet.*". http://api.jquery.com/attribute-equals-selector/
jQuery("select[id='address_subnet']") will only match "address_subnet". http://api.jquery.com/attribute-starts-with-selector/
Updated by Grischa Zengel almost 11 years ago
The error is the semicolon after
if (set_value == true);
Updated by Phillip Davis almost 11 years ago
Thanks for spotting that semi-colon - I spent a while trying to work out what going on, and obviously didn't stare hard enough at every char.
I made another pull request: https://github.com/pfsense/pfsense/pull/896
Updated by Phillip Davis almost 11 years ago
Applied in changeset 4dd00d25d5fc3d5a0b73930cf86685d4c1430a2e.
Updated by Anonymous almost 11 years ago
Applied in changeset f71b440bf16ec3cd8164325f287d8c93b5dfd476.
Updated by Phillip Davis almost 11 years ago
Applied in changeset f70adc82457c038159b4f8edd775bcf1cc498d03.
Updated by Renato Botelho over 10 years ago
- Status changed from Feedback to Resolved