Project

General

Profile

Bug #3535

Selecting "LAN" as "WAN" in Multi-WAN Traffic Shaper wizard breaks the ruleset

Added by Jim Pingle about 4 years ago. Updated over 3 years ago.

Status:
Resolved
Priority:
Normal
Category:
Traffic Shaper
Target version:
Start date:
03/20/2014
Due date:
% Done:

100%

Affected Version:
2.1
Affected Architecture:
All

Description

Using the traffic shaper wizard with PRIQ, if you choose to give a protocol lower priority on the "Raise or Lower Other Applications" step of the wizard, it generates an invalid ruleset.

: pfctl -f /tmp/rules.debug
pfctl: qDefault and qOthersLow have the same priority
/tmp/rules.debug:66: errors in queue definition
pfctl: Syntax error in config file: pf rules not loaded

As you can see in the rules, it has given both a priority of 3:

    59   altq on  em1 priq queue {  qACK,  qDefault,  qP2P,  qVoIP,  qGames,  qOthersHigh,  qOthersLow,  qLink  } 
    60   queue qACK on em1 priority 6 priq (  ecn  )  
    61   queue qDefault on em1 priority 3 priq (  ecn  , default  )  
    62   queue qP2P on em1 priority 1 priq (  ecn  )  
    63   queue qVoIP on em1 priority 7 priq (  ecn  )  
    64   queue qGames on em1 priority 5 priq (  ecn  )  
    65   queue qOthersHigh on em1 priority 4 priq (  ecn  )  
    66   queue qOthersLow on em1 priority 3 priq (  ecn  )  
    67   queue qLink on em1 priority 2 qlimit 500 priq (  ecn  , default  ) 

PRIQ can use priorities from 0-15 so it would make sense to shift the other priorities higher in the PRIQ case. CBQ and HFSC can only use 1-7.

Associated revisions

Revision 070aeff3
Added by Renato Botelho almost 4 years ago

Just show right type of interfaces (LAN/WAN) on traffic shapper wizards, it fixes #3535

History

#1 Updated by Jim Pingle about 4 years ago

The main problem with this was actually the wrong interface selected in the wizard.

If you select "LAN" as the "WAN" using this wizard since "LAN" is assumed to be LAN, so it creates overlapping queues.

So user error but maybe something we should detect/warn against since it's easy to overlook.

#2 Updated by Jim Pingle about 4 years ago

  • Subject changed from Using "raise/lower other applications" with PRIQ breaks the ruleset to Selecting "LAN" as "WAN" in Multi-WAN Traffic Shaper wizard breaks the ruleset
  • Target version changed from 2.1.1 to 2.2

Fixing description and pushing to 2.2.

#3 Updated by Jim Thompson almost 4 years ago

  • Assignee set to Renato Botelho

#4 Updated by Renato Botelho almost 4 years ago

  • Status changed from New to Feedback
  • % Done changed from 0 to 100

#5 Updated by Chris Buechler over 3 years ago

  • Status changed from Feedback to Resolved

fixed

Also available in: Atom PDF