Bug #3645
closed
Many Call-time Pass-by-reference instances in packages need fixed for PHP 5.5
100%
Description
PHP 5.5 has deprecated call-time pass-by-reference, but many packages still use it for input validation and other purposes. These will need to be cleaned up as they are found.
I added a post to the forum describing how to fix it for other package maintainers to use as a reference:
https://forum.pfsense.org/index.php?topic=76632.0
Many of the fixes will be simple, but the ones using the pfSense function do_input_validation() will be more problematic as they will require a version test to ensure the package calls the correct version for the platform it's being run upon. On 2.0.x and before the function definition in pfSense does not include a reference, on 2.1 and later it does.
Updated by Jim Pingle over 10 years ago
Most of them have been fixed except for some packages known to be actively maintained by community members. Instructions for fixing and a list of affected packages can be found here:
Updated by
Updated by Renato Botelho over 10 years ago
- Status changed from New to Feedback
- % Done changed from 0 to 100
I believe they are all fixed
Updated by Chris Buechler about 10 years ago
- Status changed from Feedback to Resolved
Should be covered. If there are any remaining, specific tickets can be opened.