Bug #3890
closed
Aliases multiple CIDR ranges show error message
100%
Description
Hi
If you create a new IP alias for network white-listing with any CIDR ranges separated by a space, pfsense WILL add them but show an error. I think this is a bug.
Here is an example list of CIDR ranges that were pasted into Network field then click submit, a picture of the error attached also you will see the CIDR ranges were added successfully but the error message appeared.
65.54.54.128/25 65.55.121.128/27 65.55.127.0/24 111.221.17.128/27 111.221.22.64/26 111.221.76.96/27 111.221.76.128/25 111.221.77.0/26 134.170.0.0/25 157.55.40.128/25 157.55.46.0/27 157.55.46.64/26 157.55.104.96/27 157.55.229.128/27 157.55.232.128/26 157.55.238.0/25 207.46.5.0/24 207.46.7.128/27 207.46.57.0/25 23.96.208.238 23.97.64.252 23.97.68.113 23.97.70.147 23.97.72.158 23.97.72.161 23.97.72.165 23.97.98.128 23.97.99.4 23.97.99.164 23.97.100.76 23.97.100.92 23.97.100.105 23.97.100.152 23.97.102.90 23.97.148.36 23.97.148.228 23.98.66.168 23.98.69.116 23.98.70.90 23.99.129.26 23.99.129.173 23.99.194.77 23.99.196.232 23.99.226.167 23.99.227.124 23.102.64.16 23.102.64.255 23.102.65.171 23.102.65.203 23.102.65.221 65.52.64.61 65.52.64.230 65.52.136.224 65.52.144.125 65.52.148.27 65.52.184.75 65.52.196.64 65.52.228.75 65.52.228.100 65.52.236.160 65.52.244.66 65.54.54.32/27 65.54.55.201 65.54.74.0/23 65.54.80.0/20 65.54.165.0/25 65.55.86.0/23 65.55.233.0/27 65.55.239.168 70.37.56.152 70.37.97.234 70.37.128.0/23 70.37.142.0/23 70.37.159.0/24 70.37.160.72 70.37.160.202 94.245.68.0/22 94.245.82.0/23 94.245.84.0/24 94.245.86.0/24 94.245.88.223 94.245.88.194 94.245.117.53 94.245.108.85 111.221.16.0/21 111.221.24.0/21 111.221.70.0/25 111.221.71.0/25 111.221.111.196 111.221.127.112/28 132.245.0.0/16 134.170.0.0/16 137.135.47.6 137.135.47.4 137.135.47.28 137.116.32.43 137.116.32.61 137.116.48.66 137.116.48.69 137.116.64.162 137.116.129.62/32 137.117.99.175 137.117.103.21 137.135.41.12/32 137.135.42.195/32 137.135.43.100/32 137.135.44.5/32 137.135.44.73/32 137.135.48.128/32 138.91.17.43 138.91.17.108 138.91.18.52 138.91.2.208 138.91.2.210 138.91.2.212 157.55.59.128/25 157.55.80.175 157.55.80.182 157.55.84.13/32 157.55.84.19/32 157.55.84.80/32 157.55.84.237/32 157.55.130.0/25 157.55.145.0/25 157.55.155.0/25 157.55.168.18 157.55.176.63 157.55.185.100 157.55.194.46 157.55.208.198 157.55.227.192/26 157.55.252.101 157.56.0.0/16 168.61.33.178/32 168.61.35.252/32 168.61.36.121 168.61.37.63/32 168.61.38.105 168.61.39.14/32 168.61.82.81/32 168.61.83.48/32 168.61.85.180/32 168.61.85.193/32 168.61.144.76 168.61.208.197 168.62.4.28 168.62.11.24 168.62.11.117 168.62.16.112 168.62.16.140 168.62.16.149 168.62.24.104 168.62.24.114 168.62.24.150 168.62.41.25 168.62.42.89 168.62.52.198 168.62.52.203 168.62.60.71 168.62.60.80 168.62.104.146 168.62.176.34 168.62.179.4 168.62.180.151 168.63.16.66/32 168.63.16.112/32 168.63.16.114/32 168.63.16.141 168.63.17.221/32 168.63.25.227 168.63.27.2 168.63.166.200 168.63.165.67 168.63.164.177 168.63.208.73/32 168.63.213.203/32 168.63.214.35/32 168.63.216.117/32 168.63.250.173/32 168.63.252.39/32 168.63.252.71/32 191.233.32.111 191.233.32.201 191.234.6.0/24 191.235.135.139 191.235.135.222 191.236.192.179 191.237.128.159 191.238.80.160 191.238.81.69 191.238.83.220 207.46.57.128/25 207.46.70.0/24 207.46.73.250 207.46.198.0/25 207.46.206.0/23 207.46.216.54 213.199.128.58 213.199.128.91 213.199.148.0/23 213.199.182.128/25
Files
Updated by Phillip Davis about 10 years ago
It was kind-of a feature:) It fills out all the rows when you press Save the first time but tells you that the data is invalid. You press Save a second time and it accepts the data. That is odd behaviour.
I re-worked the validation so it expands any entry like that, or IP range, into its full form before doing the validation. Now it validates the first time and Saves.
https://github.com/pfsense/pfsense/pull/1296
In 2.2 there have been some enhancements to aliases, so it is not automatic to apply my change to the 2.2 version. Tomorrow I will do some manual cut-and-paste to also implement for 2.2
Updated by Phillip Davis about 10 years ago
The version for 2.2 was not so difficult to integrate:
https://github.com/pfsense/pfsense/pull/1297
Updated by Chris Buechler about 10 years ago
- Target version set to 2.2
Phil's pull request to fix this still pending, some reason that hasn't been accepted?
Updated by Renato Botelho about 10 years ago
- Assignee set to Renato Botelho
Just need tests. I'll take care of it.
Updated by Renato Botelho about 10 years ago
- Status changed from New to Feedback
- % Done changed from 0 to 100
Pull request has been merged
Updated by Chris Buechler about 10 years ago
- Status changed from Feedback to Resolved