Add GUI setting for VLANs PCP
Add support for optionally setting VLANs priority (PCP) through the GUI, saved as part of the xml configuration.
Suggested patches are attached (also include fix for #3737).
|pf_pcp_git.diff (12.2 KB) pf_pcp_git.diff||PHP interface patch (pfSense GIT)||Clement Barnier, 12/20/2014 08:34 AM|
|pf_pcp_source.diff (12.5 KB) pf_pcp_source.diff||Source patch||Clement Barnier, 12/20/2014 08:34 AM|
|pf_pcp_tools.diff (1.24 KB) pf_pcp_tools.diff||pfPorts patch (php55-pfSense-module)||Clement Barnier, 12/20/2014 08:34 AM|
|pf_pcp_git.diff (12.2 KB) pf_pcp_git.diff||Corrected PHP interface patch (missing brackets)||Clement Barnier, 01/03/2015 05:33 AM|
Updated by Clement Barnier almost 7 years ago
I just realized that the blob in the git diff regarding configuration compatibility has a few missing brackets. I guess I decided to change it at the last minute.
Tested on 2.2-RC without problem.
Updated by Chris Christensen over 6 years ago
I tested this patch using 2.2.3-Release:
- https://github.com/pfsense/pfsense-tools/compare/pfsense:RELENG_2_2_3...christianchristensen:4133 (PR: https://github.com/pfsense/pfsense-tools/pull/6 )
- https://github.com/pfsense/pfsense/compare/RELENG_2_2_3...christianchristensen:4133 (PR: https://github.com/pfsense/pfsense/pull/1757 )
I used the build instructions from: https://forum.pfsense.org/index.php?topic=83785.0 to generate an image.
This all appears to have worked very nicely - the UI is exposed and the added functionality appears to function. For me was related to Google Fiber QoS ( https://support.google.com/fiber/faq/3333053?hl=en ) that requires 802.1Q VLAN pcp set to 2. (otherwise upload speed is rate-limited)
As for the test, the results speak:
Updated by Chris Buechler almost 6 years ago
This looks to work fine. It's configured correctly, and the appropriate PCP mark is on the traffic.
Chris or anyone else with a real world scenario here, could you please test the latest 2.3 snapshot from https://snapshots.pfsense.org and report back?