Feature #4133
closed
Add GUI setting for VLANs PCP
Added by Clement Barnier almost 10 years ago. Updated almost 9 years ago.
100%
Description
Add support for optionally setting VLANs priority (PCP) through the GUI, saved as part of the xml configuration.
Suggested patches are attached (also include fix for #3737).
Files
| pf_pcp_git.diff (12.2 KB) pf_pcp_git.diff | PHP interface patch (pfSense GIT) | Clement Barnier, 12/20/2014 08:34 AM | |
| pf_pcp_source.diff (12.5 KB) pf_pcp_source.diff | Source patch | Clement Barnier, 12/20/2014 08:34 AM | |
| pf_pcp_tools.diff (1.24 KB) pf_pcp_tools.diff | pfPorts patch (php55-pfSense-module) | Clement Barnier, 12/20/2014 08:34 AM | |
| pf_pcp_git.diff (12.2 KB) pf_pcp_git.diff | Corrected PHP interface patch (missing brackets) | Clement Barnier, 01/03/2015 05:33 AM |
Updated by Renato Botelho almost 10 years ago
- Target version changed from 2.2 to 2.2.1
Target to 2.2.1 for future review, 2.2 is now in RC state
Updated by Clement Barnier almost 10 years ago
- File pf_pcp_git.diff pf_pcp_git.diff added
I just realized that the blob in the git diff regarding configuration compatibility has a few missing brackets. I guess I decided to change it at the last minute.
Tested on 2.2-RC without problem.
Updated by
Updated by Chris Buechler almost 10 years ago
- Target version changed from 2.2.1 to 2.2.2
Updated by Chris Buechler over 9 years ago
- Target version changed from 2.2.2 to 2.2.3
Updated by Chris Buechler over 9 years ago
- Target version changed from 2.2.3 to 2.3
Updated by Chris Christensen over 9 years ago
I tested this patch using 2.2.3-Release:
- https://github.com/pfsense/pfsense-tools/compare/pfsense:RELENG_2_2_3...christianchristensen:4133 (PR: https://github.com/pfsense/pfsense-tools/pull/6 )
- https://github.com/pfsense/pfsense/compare/RELENG_2_2_3...christianchristensen:4133 (PR: https://github.com/pfsense/pfsense/pull/1757 )
I used the build instructions from: https://forum.pfsense.org/index.php?topic=83785.0 to generate an image.
This all appears to have worked very nicely - the UI is exposed and the added functionality appears to function. For me was related to Google Fiber QoS ( https://support.google.com/fiber/faq/3333053?hl=en ) that requires 802.1Q VLAN pcp set to 2. (otherwise upload speed is rate-limited)
As for the test, the results speak:
Updated by Chris Buechler over 9 years ago
Thanks Chris! We'll get this integrated for 2.3.
Updated by Renato Botelho about 9 years ago
- Assignee changed from Renato Botelho to Luiz Souza
Luiz, can you please check kernel patch available at https://github.com/pfsense/pfsense-tools/pull/6?
Updated by Luiz Souza almost 9 years ago
- Status changed from New to Feedback
- % Done changed from 0 to 100
All the parts are committed, should work out-of-box in 2.3.
Updated by Chris Buechler almost 9 years ago
This looks to work fine. It's configured correctly, and the appropriate PCP mark is on the traffic.
Chris or anyone else with a real world scenario here, could you please test the latest 2.3 snapshot from https://snapshots.pfsense.org and report back?
Updated by Chris Buechler almost 9 years ago
- Status changed from Feedback to Resolved
Chris confirmed via email that this worked fine (aside from hitting #5453 and having other issues from that)