Project

General

Profile

Bug #4142

certificate manager certificates that are in use by packages can be deleted

Added by Pi Ba over 4 years ago. Updated over 3 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
Certificates
Target version:
Start date:
12/24/2014
Due date:
% Done:

100%

Estimated time:
Affected Version:
All
Affected Architecture:
All

Description

certificatemanager, certificates that are in use can be deleted

When a certificate is in use by a OpenVPN server it cannot be deleted, however when a certificate is in use by HAProxy-devel, it can be deleted. There needs to be a way for pfSense to query what certificates are used by packages.

For example [https://github.com/pfsense/pfsense/pull/1081]

Associated revisions

Revision 29e6a815 (diff)
Added by Renato Botelho over 3 years ago

Do not allow certificate to be deleted if it's been used by a package. Fixes #4142

History

#1 Updated by Chris Buechler over 4 years ago

  • Status changed from New to Confirmed
  • Target version changed from 2.2 to 2.2.1
  • Affected Version changed from 2.1.5 to All

#2 Updated by Jim Thompson over 4 years ago

  • Assignee set to Renato Botelho

#3 Updated by Chris Buechler over 4 years ago

  • Target version changed from 2.2.1 to 2.2.2

#4 Updated by Chris Buechler over 4 years ago

  • Target version changed from 2.2.2 to 2.2.3

#5 Updated by Chris Buechler about 4 years ago

  • Subject changed from certificatemanager, certificates that are in use can be deleted to certificate manager certificates that are in use by packages can be deleted
  • Target version changed from 2.2.3 to 2.3

#6 Updated by Renato Botelho over 3 years ago

  • Status changed from Confirmed to Feedback
  • % Done changed from 0 to 100

#7 Updated by Pi Ba over 3 years ago

Thanks, change works regarding hiding the delete button when a package uses the 'plugin_certificates' function to report used certificates.

With regard to 'speed' it might improve performance to 'cache' the $certificates_used_by_packages variable during building the certificate page if users have a lot of certificates there. Currently its calling every package again and again for every certificate, while the package returns all used certificates in a array every time. (I havent tested how many packages & certificates & package configuration are needed before having a noticeable effect.)

It would be nice to show which packages are using the certificate though. As currently the 'In Use' column can be empty while the delete button is hidden. Depending on the number of packages installed and if someone is taking over a preexisting configuration that would help them find the right location. Perhaps even use the 'usedby' attribute to show additional information provided by the package in a popup window?

#8 Updated by Renato Botelho over 3 years ago

  • Status changed from Feedback to Assigned
  • Assignee changed from Renato Botelho to Steve Beaver

The part of https://github.com/pfsense/pfsense/pull/1081 that added the information about what packages are using that certificate was lost during bootstrap integration, moving to Steve to check best way to show this information

#9 Updated by Steve Beaver over 3 years ago

  • Status changed from Assigned to Resolved
  • Assignee deleted (Steve Beaver)

Lost functionality has been restored and tested by Renato :)

Also available in: Atom PDF