Project

General

Profile

Actions
Copy link

Bug #4148

closed

gen_subnet returns incorrect result for IPv6

Added by Chris Buechler almost 10 years ago. Updated almost 10 years ago.

Status:
Resolved
Priority:
High
Assignee:
Ermal Luçi
Category:
Interfaces
Target version:
2.2
Start date:
12/26/2014
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
All
Affected Architecture:

Description

There is a pull request to fix this:
https://github.com/pfsense/pfsense/pull/958

#4141 shows one instance where this causes problems.

Is there a reason we haven't merged that pull request? Aside from the fact Stilez apparently doesn't have a CLA on file, added comment there to hopefully get that taken care of.

Actions
Copy link
 #1

Updated by Chris Buechler almost 10 years ago

stilez has an ICLA on file now so we can merge that. It looks fine to me, to Ermal for review.

Actions
Copy link
 #2

Updated by Renato Botelho almost 10 years ago

Chris Buechler wrote:

stilez has an ICLA on file now so we can merge that. It looks fine to me, to Ermal for review.

Except for a typo I've found and commented, the PR looks ok to me too. Just waiting to check Ermal's opinion

Actions
Copy link
 #3

Updated by Renato Botelho almost 10 years ago

  • Status changed from Confirmed to Feedback
  • % Done changed from 0 to 100

Pull request has been merged.

Actions
Copy link
 #4

Updated by Chris Buechler almost 10 years ago

  • Status changed from Feedback to Resolved

fixed

Actions
Copy link
 #5

Updated by Pi Ba almost 10 years ago

Thanks gen_subnet() is fixed, however issue #4141 still exists as ip_in_subnet(11.22.33.5,abcd::/64) needs fixing to.

Actions
Copy link

Also available in: Atom PDF