Bug #4148
closedgen_subnet returns incorrect result for IPv6
100%
Description
There is a pull request to fix this:
https://github.com/pfsense/pfsense/pull/958
#4141 shows one instance where this causes problems.
Is there a reason we haven't merged that pull request? Aside from the fact Stilez apparently doesn't have a CLA on file, added comment there to hopefully get that taken care of.
Updated by Chris Buechler over 9 years ago
stilez has an ICLA on file now so we can merge that. It looks fine to me, to Ermal for review.
Updated by Renato Botelho over 9 years ago
Chris Buechler wrote:
stilez has an ICLA on file now so we can merge that. It looks fine to me, to Ermal for review.
Except for a typo I've found and commented, the PR looks ok to me too. Just waiting to check Ermal's opinion
Updated by Renato Botelho over 9 years ago
- Status changed from Confirmed to Feedback
- % Done changed from 0 to 100
Pull request has been merged.
Updated by Pi Ba over 9 years ago
Thanks gen_subnet() is fixed, however issue #4141 still exists as ip_in_subnet(11.22.33.5,abcd::/64) needs fixing to.