Project

General

Profile

Bug #4510

Crash & reboot loop when configure PPPoE server on PPPoE client interface

Added by Nestor Mahno about 6 years ago. Updated 5 months ago.

Status:
Resolved
Priority:
Normal
Category:
PPPoE Server
Target version:
Start date:
03/11/2015
Due date:
% Done:

100%

Estimated time:
Affected Version:
All
Affected Architecture:
All
Release Notes:
Default

Description

affected version: 2.2-RELEASE (i386) ; 2.1.5-RELEASE (i386)

prerequisite: WAN interface with PPPoE type configuration

steps to reproduce: Turn on a PPPoE server on WAN interface then "applay" button

checked: more then 10 systems (all with old Intel P4/86 processor)

some log strings:

Fatal trap 12: page fault while in kernel mode
cpuid = 1; apic id = 01
fault virtual address = 0x4
fault code = supervisor write, page not present
instruction pointer = 0x20:0xc0e2a04e
stack pointer = 0x28:0xecf3798c
frame pointer = 0x28:0xecf379c0
code segment = base 0x0, limit 0xfffff, type 0x1b = DPL 0, pres 1, def32 1, gran 1
processor eflags = interrupt enabled, resume, IOPL = 0
current process = 6748 (php-fpm)

Associated revisions

Revision 4f911030 (diff)
Added by Viktor Gurov 7 months ago

PPPoE Server interface input validation. Issue #4510

History

#1 Updated by Chris Buechler about 6 years ago

  • Subject changed from Crash & reboot loop when configure pppoe server on WAN interface to Crash & reboot loop when configure PPPoE server on PPPoE client interface
  • Status changed from New to Confirmed
  • Assignee deleted (Nestor Mahno)
  • Affected Version changed from 2.2 to All
  • Affected Architecture All added
  • Affected Architecture deleted (i386)

It's not valid to configure a PPPoE server on an interface that's a PPPoE client. We'll need to add input validation to prevent such a configuration.

#3 Updated by Jim Pingle 7 months ago

  • Status changed from Confirmed to Pull Request Review
  • Target version set to 2.5.0

#4 Updated by Renato Botelho 7 months ago

  • Status changed from Pull Request Review to Feedback
  • Assignee set to Renato Botelho
  • % Done changed from 0 to 100

PR has been merged. Thanks!

#5 Updated by Max Leighton 5 months ago

  • Status changed from Feedback to Resolved

Tested in

2.5.0-DEVELOPMENT (amd64)
built on Sun Nov 01 13:02:32 EST 2020
FreeBSD 12.2-STABLE

Fix works as expected. Pseudo interfaces do not appear in the dropdown for creating PPPoE server any longer.

Marking the ticket resolved.

Also available in: Atom PDF