pfSense

I just made a pull request for the first tiny error I noticed:
https://github.com/pfsense/pfsense/pull/1736

I am happy to look at this stuff. I have some code to check and;
a) not allow you to enable a route that uses a disabled gateway - either by the enable/disable buttons on the front Routes page, or by clearing the disabled checkbox when editing the route.
b) check the address family thing better, so if the route is disabled it will allow it to match with a gateway that is disabled (which is the problem with the silly message) - thus checking the address family matches even if the route and gateway are disabled.

The other problem is that the user can disable a gateway that has enabled routes. That code should also check and only allow the user to disable a gateway if all routes using it are already disabled. I will fix that up also.

After all that there should only be valid changes able to made made from the GUI. Hopefully those changes will all be implemented correctly - but I will check that because the "Related to this" paragraph looks like it will still be a problem.

Isn't input validation fun :)

Validation of enable/disable of gateways and static routes
Pull request: https://github.com/pfsense/pfsense/pull/1738

That stops any invalid combinations of enabled/disabled gateways and static routes from being saved, and allows the valid ones.

In the next day or 2 I will try what happens if you make various changes to static routes and gateways without pressing apply after every step. And will fix whatever inconsistency I can see there.

Applied in changeset 028ff8f8a3d7c09ee5604d6f3eadcdaaef1610c7.