Actions
Bug #5027
closedsystem_gateways_edit.php needs Advanced clean up
Description
Similar to what you did on firewall rules page for instance.
Actions
Added by Chris Buechler about 9 years ago. Updated about 9 years ago.
Description
Similar to what you did on firewall rules page for instance.
Added toggle action to advanced options section
Applied in changeset pfsense:b18a5d894d549df3522427d11d64a00d72443328.
The old code checked if any of the advanced fields were set to non-default values.
If all advanced fields are at their default values then the Advanced button is shown on page load,
otherwise all the fields are shown (so the user can immediately see that they have specified some non-default Advanced setting).
Code around here did it:
https://github.com/pfsense/pfsense/blob/RELENG_2_2/usr/local/www/system_gateways_edit.php#L750
This applies in most of the other places were and Advanced button hides a group of advanced fields.
Sorry, I don't have anything to quickly test this on right now.
Does that behavior still work?
What Phil noted is one of the things I was going to get to eventually. For now, more keeping it to things that are completely broken.
Phil: if you're up for helping test, right now probably your best bet is checking out the bootstrap branch, cd to its src dir, and 'scp -r * root@<IP>:/' to a clean 2.2.4 install. Only on a test VM. :)
At least some, if not all, screens no longer have that.
I opened a new ticket on this general issue since it's separate, #5045.
should be an advanced button like on firewall_rules_edit.php rather than a checkbox
Checkbox converted to button
Applied in changeset pfsense:d398152473bc7fece9d4b647c27d26c723f380c8.