Bug #5196
closed
Incorrect text about DNS servers on services_dhcp.php
100%
Description
1) After the advanced options and save button, and before the static mappings table, this text is shown:
--------
Note: The DNS servers entered in System: General setup (or the DNS forwarder, if enabled) will be assigned to clients by the DHCP server.
--------
2) At the end of the 4 boxes to enter DNS servers, this text is shown:
--------
NOTE: leave blank to use the system default DNS servers - this interface's IP if DNS Forwarder or Resolver is enabled, otherwise the servers configured on the General page.
--------
IMHO the note (2) is correct, and note (1) is wrong and should be removed.
This looks like it has been like this in all versions for many years. Could easily be fixed in RELENG_2_2 and also in master for 2.3
Someone please confirm if I am right, or if my brain is muddled. I am happy to make the necessary changes.
Updated by Phillip Davis over 8 years ago
Pull request for RELENG_2_2 https://github.com/pfsense/pfsense/pull/1933 - assuming what I am reporting here is valid.
The same would also need to be done in master once the bootstrap conversion of services_dhcp.php is complete/stable.
Updated by Phillip Davis over 8 years ago
https://github.com/pfsense/pfsense/pull/1933 has been committed to RELENG_2_2.
sbeaver-netgate has been asked to make the equivalent change in the bootstrap code on master.
So status is 50% completed.
Updated by Renato Botelho over 8 years ago
- Status changed from New to Feedback
- % Done changed from 0 to 100
Pull request has been merged. Thanks!
Updated by Chris Buechler over 8 years ago
- Status changed from Feedback to Resolved
that was a hold over from m0n0wall still. Better now, thanks!