Bug #5364
closed
IPsec status pages show all time units as seconds
100%
Description
The vici plugin outputs all status times in seconds, where SMP status output hours for times > 1 hour, minutes for times > 1 minute and < 1 hour, and seconds for times < 1 minute. It works fine, so we'll target 2.3 for this, just isn't user-friendly.
Updated by Jim Thompson about 9 years ago
- Priority changed from Normal to Very Low
I'm OK with 'seconds'.
Updated by Jim Pingle about 9 years ago
We do have a function for this: convert_seconds_to_hms($sec) source:src/etc/inc/pfsense-utils.inc#L1171 - shouldn't be too hard to plumb in where needed since the values are already being printed by PHP, no?
Updated by Jim Thompson about 9 years ago
- Assignee set to Matthew Smith
as suggested in chat, "xxxxxx seconds (hh:mm:ss)" seems best.
assigned
Updated by Matthew Smith about 9 years ago
- Status changed from Confirmed to Feedback
- % Done changed from 0 to 100
Applied in changeset 00ae4060fadd581e8bea44fc2c45e9236615849d.
Updated by Chris Buechler about 9 years ago
- Status changed from Feedback to Resolved
Looks good, thanks! Not a big deal but most people don't recognize tens of thousands of seconds at a glance, and it's easy to make human-readable.