Project

General

Profile

Actions

Bug #5364

closed

IPsec status pages show all time units as seconds

Added by Chris Buechler over 8 years ago. Updated over 8 years ago.

Status:
Resolved
Priority:
Very Low
Assignee:
Category:
IPsec
Target version:
Start date:
11/02/2015
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
2.2.5
Affected Architecture:

Description

The vici plugin outputs all status times in seconds, where SMP status output hours for times > 1 hour, minutes for times > 1 minute and < 1 hour, and seconds for times < 1 minute. It works fine, so we'll target 2.3 for this, just isn't user-friendly.

Actions #1

Updated by Jim Thompson over 8 years ago

  • Priority changed from Normal to Very Low

I'm OK with 'seconds'.

Actions #2

Updated by Jim Pingle over 8 years ago

We do have a function for this: convert_seconds_to_hms($sec) source:src/etc/inc/pfsense-utils.inc#L1171 - shouldn't be too hard to plumb in where needed since the values are already being printed by PHP, no?

Actions #3

Updated by Jim Thompson over 8 years ago

  • Assignee set to Matthew Smith

as suggested in chat, "xxxxxx seconds (hh:mm:ss)" seems best.

assigned

Actions #4

Updated by Matthew Smith over 8 years ago

  • Status changed from Confirmed to Feedback
  • % Done changed from 0 to 100
Actions #5

Updated by Chris Buechler over 8 years ago

  • Status changed from Feedback to Resolved

Looks good, thanks! Not a big deal but most people don't recognize tens of thousands of seconds at a glance, and it's easy to make human-readable.

Actions

Also available in: Atom PDF