Project

General

Profile

Bug #5433

diag_logs.php - Line wrapping issues with long unbroken lines

Added by Jim Pingle over 3 years ago. Updated over 3 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Target version:
Start date:
11/12/2015
Due date:
% Done:

80%

Estimated time:

Description

Looks like if there is a log line long enough it causes the timestamp column to wrap, too, which negatively impacts the formatting for many more lines than it should.

Can that one column be set not to wrap?

Also in that case it the line is still causing a horizontal scroll bar since it's all run together and not breaking properly it never wraps. (See #5395 for more discussion on that)

Associated revisions

Revision 247418f1 (diff)
Added by jeroen van breedam over 3 years ago

proposed fix Bug #5433

History

#1 Updated by Steve Beaver over 3 years ago

  • Status changed from Confirmed to Feedback
  • Assignee changed from Steve Beaver to Jim Pingle

Fixed as requested.

#2 Updated by Steve Beaver over 3 years ago

  • % Done changed from 0 to 100

#3 Updated by jeroen van breedam over 3 years ago

there's still the issue of the horizontal scrollbar.

i came across a PR for releng2_2 that had this solution for it: https://github.com/pfsense/pfsense/pull/2002/files

style="word-wrap:break-word; max-width:970px;

i've been trying max-width:inherit; but that doesn't seem to work // max-width:calc(100%-200px) ; doesn't work.
anyways, maybe someone can find a way todo this cleanly without setting static # px

#4 Updated by Jim Pingle over 3 years ago

  • Status changed from Feedback to Assigned
  • Assignee changed from Jim Pingle to Steve Beaver
  • % Done changed from 100 to 80

The time column is good, still have a wrapping issue with long unbroken lines like these:

Nov 12 08:01:17     kernel: Features=0xbfebfbff<FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,MCA,CMOV,PAT,PSE36,CLFLUSH,DTS,ACPI,MMX,FXSR,SSE,SSE2,SS,HTT,TM,PBE>
Nov 12 08:01:17     kernel: Features2=0x43d8e3bf<SSE3,PCLMULQDQ,DTES64,MON,DS_CPL,VMX,EST,TM2,SSSE3,CX16,xTPR,PDCM,SSE4.1,SSE4.2,MOVBE,POPCNT,TSCDLT,AESNI,RDRAND>

#5 Updated by Steve Beaver over 3 years ago

One solution is to add word break opportunity tags every few character to allow the strings to break even though there are no spaces. I'll put together a demonstration tomorrow.

#6 Updated by jeroen van breedam over 3 years ago

please check https://github.com/pfsense/pfsense/pull/2062

this works on my home setup, tested on chrome&firefox; no clue if this works in every circumstance.

#7 Updated by Steve Beaver over 3 years ago

  • Status changed from Assigned to Feedback
  • Assignee changed from Steve Beaver to Jim Pingle

Addressed in PR #2062 now merged.

#8 Updated by Jim Pingle over 3 years ago

  • Status changed from Feedback to Resolved

Looks good here now, wrapping is happening only where it should and there is no more horizontal scroll, thanks!

Also available in: Atom PDF