Project

General

Profile

Bug #5440

system_usermanager_settings.php - When no Auth Server is defined, it should default to Local Database

Added by Jim Pingle about 4 years ago. Updated about 4 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Target version:
Start date:
11/13/2015
Due date:
% Done:

0%

Estimated time:

Description

On system_usermanager_settings.php when there is no Auth Server defined in config.xml, the drop-down for Authentication Server should default to "Local Database".

Currently the drop-down defaults to whatever is first in the list, which if the user has any servers defined, is a custom server and not what is actually active at the time (which is really "Local Database").

Associated revisions

History

#1 Updated by jeroen van breedam about 4 years ago

this might to work: https://github.com/pfsense/pfsense/pull/2063

on a related note:

if ($_POST['authmode'] != "local") {
        //more code here....


above shows up in system_usermanager_settings.php on releng2_2 & master. Yet authmode is not/never set to "local" ; it is set to "Local Database" (unless i'm missing something).

#2 Updated by Steve Beaver about 4 years ago

  • Status changed from Confirmed to Feedback
  • Assignee changed from Steve Beaver to Jim Pingle

PR 2063 applied
The error seems to go back to at least pfSense 2.0 so please test carefully.

#3 Updated by Phillip Davis about 4 years ago

In system_usermanager_settings.php in 2.2.5 it works OK for me, and looking at the code it does indeed select Local Database from the list if 'authmode' is not set. So I wonder why Steve is saying "The error seems to go back to at least pfSense 2.0"?
In diag_authentication.php in 2.2.5 there is no code to select the system 'authmode' setting as the default - so that part is non-optimal in 2.2.5.

#4 Updated by Phillip Davis about 4 years ago

I added PR https://github.com/pfsense/pfsense/pull/2065 to backport the diag_authentication.php bit of this to RELENG_2_2
It seems to me that it is worthwhile backporting little easy fixes like this to RELENG_2_2 so they can be easily noticed against all the Bootstrap noise, and so existing 2.2.* users can easily see and get them if they wish.

#5 Updated by Phillip Davis about 4 years ago

and a suggested improvement to the diag_authentication.php for 2.3 https://github.com/pfsense/pfsense/pull/2066

#6 Updated by Jim Pingle about 4 years ago

  • Status changed from Feedback to Resolved

Seems to DTRT now.

Also available in: Atom PDF