Project

General

Profile

Actions
Copy link

Bug #5440

closed
JP JP

system_usermanager_settings.php - When no Auth Server is defined, it should default to Local Database

Bug #5440: system_usermanager_settings.php - When no Auth Server is defined, it should default to Local Database

Added by Jim Pingle almost 11 years ago. Updated almost 11 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Jim Pingle
Target version:
pfSense - 2.3
Start date:
11/13/2015
Due date:
% Done:

0%

Estimated time:

Description

On system_usermanager_settings.php when there is no Auth Server defined in config.xml, the drop-down for Authentication Server should default to "Local Database".

Currently the drop-down defaults to whatever is first in the list, which if the user has any servers defined, is a custom server and not what is actually active at the time (which is really "Local Database").

JV Updated by jeroen van breedam almost 11 years ago Actions
Copy link
 #1

this might to work: https://github.com/pfsense/pfsense/pull/2063

on a related note:

if ($_POST['authmode'] != "local") {
        //more code here....

above shows up in system_usermanager_settings.php on releng2_2 & master. Yet authmode is not/never set to "local" ; it is set to "Local Database" (unless i'm missing something).

Updated by Anonymous almost 11 years ago Actions
Copy link
 #2

  • Status changed from Confirmed to Feedback
  • Assignee changed from Anonymous to Jim Pingle

PR 2063 applied
The error seems to go back to at least pfSense 2.0 so please test carefully.

PD Updated by Phillip Davis almost 11 years ago Actions
Copy link
 #3

In system_usermanager_settings.php in 2.2.5 it works OK for me, and looking at the code it does indeed select Local Database from the list if 'authmode' is not set. So I wonder why Steve is saying "The error seems to go back to at least pfSense 2.0"?
In diag_authentication.php in 2.2.5 there is no code to select the system 'authmode' setting as the default - so that part is non-optimal in 2.2.5.

PD Updated by Phillip Davis almost 11 years ago Actions
Copy link
 #4

I added PR https://github.com/pfsense/pfsense/pull/2065 to backport the diag_authentication.php bit of this to RELENG_2_2
It seems to me that it is worthwhile backporting little easy fixes like this to RELENG_2_2 so they can be easily noticed against all the Bootstrap noise, and so existing 2.2.* users can easily see and get them if they wish.

PD Updated by Phillip Davis almost 11 years ago Actions
Copy link
 #5

and a suggested improvement to the diag_authentication.php for 2.3 https://github.com/pfsense/pfsense/pull/2066

JP Updated by Jim Pingle almost 11 years ago Actions
Copy link
 #6

  • Status changed from Feedback to Resolved

Seems to DTRT now.

Actions
Copy link

Also available in: Atom