Project

General

Profile

Actions

Bug #5503

closed

Icons used by packages are not rendering

Added by Phillip Davis almost 6 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Package System
Target version:
Start date:
11/20/2015
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
2.3
Affected Architecture:

Description

For example, when I open the Cron package GUI it looks like the attached screen shot. The edit and delete icons are not rendering.
I guess the underlying package GUI generation code has not yet been updated to the font-awesome icons and still generates references to older icons that no longer exist? or?


Files

Cron-Icons.png (44.1 KB) Cron-Icons.png Phillip Davis, 11/20/2015 10:52 AM
Actions #1

Updated by Steve Beaver almost 6 years ago

This is a static php page (not generated from XML) I believe, so the package maintainer needs to update it to be compatible with 2.3

Actions #2

Updated by Phillip Davis almost 6 years ago

You are correct.
I doubt that Cron has a "maintainer". I suspect that the packages like Cron, System Patches, Service Watchdog, ... are kind of "pfSense add-ons" developed in-house.
If no-one else looks at it I will have a go so I learn what is required, but time for bed for me now.

Actions #3

Updated by Jim Thompson almost 6 years ago

  • Assignee set to Phillip Davis

Phil volunteered

Actions #4

Updated by Kill Bill almost 6 years ago

Phillip Davis wrote:

I guess the underlying package GUI generation code has not yet been updated to the font-awesome icons and still generates references to older icons that no longer exist? or?

There simple are direct references to the old themes icons. E.g., with cron:

https://github.com/pfsense/pfsense-packages/blob/master/config/cron/cron.php#L121

All of this porting would better be done in https://github.com/pfsense/FreeBSD-ports/tree/devel/sysutils/pfSense-pkg-Cron directly, instead of adding useless version-specific shit to current package code - but someone needs to stop syncing the code with the pfsense-packages repo once it's done.

Actions #5

Updated by Phillip Davis almost 6 years ago

This is better covered by https://redmine.pfsense.org/issues/5571
I have been away from much open-source stuff last week. Now catching up on what has happened. Probably best for me not to bother converting a package until there is a good example done by an ESF person. Then I can mindlessly copy the style and save a lot of back-and-forth in pull requests :)
I suggest close this issue.

Actions #6

Updated by Jim Pingle almost 6 years ago

  • Status changed from New to Closed

Phil,

Check my thread here: https://forum.pfsense.org/index.php?topic=103481.0 and the master package conversion ticket at https://redmine.pfsense.org/issues/5568
Also I have converted three packages that may be somewhat useful as examples: AutoConfigBackup, OpenVPN Client Export, and System Patches. I started separate threads for each of those packages for testing. Will probably end up doing more this week.

I'll close this one out.

Actions

Also available in: Atom PDF