Project

General

Profile

Actions

Todo #5571

closed

Todo #5568: Convert Package PHP GUI Files to Bootstrap

Convert the pfSense package Cron (sysutils/pfSense-pkg-Cron) to Bootstrap

Added by Jim Pingle almost 6 years ago. Updated almost 6 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Cron
Target version:
Start date:
12/03/2015
Due date:
% Done:

100%

Estimated time:
Plus Target Version:

Description

Convert the pfSense package Cron (sysutils/pfSense-pkg-Cron) to Bootstrap

Actions #1

Updated by Jared Dillard almost 6 years ago

  • Status changed from New to Feedback

This is my first package to convert. Feedback appreciated.

Actions #2

Updated by Phillip Davis almost 6 years ago

@Jared - no new version is showing up. I think you need to bump the version in the various places it is recorded.

Actions #4

Updated by Jim Pingle almost 6 years ago

  • Status changed from Feedback to Assigned
A couple issues:
  • The fields on the edit page do not need htmlspecialchars on the stored values when building the form (e.g. in the addInput params), Bootstrap handles that and it will cause problems editing and saving. Edit a command with an & in it for example
  • You can build the tabs and use display_top_tabs without the extra table formatting around it.
  • Looks like the edit page has some JS in a script tag that isn't used/needed
  • The edit page is in dire need of more friendly field names and help text. Kick it over to me if you want me to do that part.
Actions #5

Updated by Jim Pingle almost 6 years ago

One more: There is a double confirmation prompt when deleting an item from the list

Actions #6

Updated by Jared Dillard almost 6 years ago

  • Assignee changed from Jared Dillard to Jim Pingle

I made all the changes except the "friendly field names and help text". I wasn't sure if I should increment the package number in this case though so I didn't.

Actions #7

Updated by Jim Pingle almost 6 years ago

  • Status changed from Assigned to Feedback
  • % Done changed from 0 to 100

New version pushed, should show up for testing in 15-20 minutes or so (0.3.5)

Actions #8

Updated by Chris Buechler almost 6 years ago

  • Status changed from Feedback to Resolved

looks good

Actions

Also available in: Atom PDF