pfSense » pfSense Packages

This is my first package to convert. Feedback appreciated.

• The fields on the edit page do not need htmlspecialchars on the stored values when building the form (e.g. in the addInput params), Bootstrap handles that and it will cause problems editing and saving. Edit a command with an & in it for example
• You can build the tabs and use display_top_tabs without the extra table formatting around it.
• Looks like the edit page has some JS in a script tag that isn't used/needed
• The edit page is in dire need of more friendly field names and help text. Kick it over to me if you want me to do that part.

I made all the changes except the "friendly field names and help text". I wasn't sure if I should increment the package number in this case though so I didn't.

New version pushed, should show up for testing in 15-20 minutes or so (0.3.5)

looks good