Project

General

Profile

Bug #5905

Hard coded background colors on status_gateways.php

Added by Jared Dillard over 3 years ago. Updated over 3 years ago.

Status:
Resolved
Priority:
Low
Assignee:
Category:
Web Interface
Target version:
Start date:
02/17/2016
Due date:
% Done:

0%

Estimated time:
Affected Version:
2.3
Affected Architecture:

Description

I noticed hardcoded background colors on status_gateways.php that haven't been converted to bootstrap classes (success, warning, etc) yet.

I did a grep for the color below and it showed some possible places where they might be hiding.

grep -rn "90EE90" returns:

/src/usr/local/www/includes/functions.inc.php:79: $bgcolor = "#90EE90"; // lightgreen
/src/usr/local/www/status_gateway_groups.php:68: define('LIGHTGREEN', '#90EE90');
/src/usr/local/www/status_gateways.php:67: define('LIGHTGREEN', '#90EE90');
/src/usr/local/www/status_lb_pool.php:74: define('LIGHTGREEN', '#90EE90');
/src/usr/local/www/status_lb_vs.php:65: define('LIGHTGREEN', '#90EE90');

Associated revisions

Revision 7dbbf1f5 (diff)
Added by Jared Dillard over 3 years ago

Ticket #5905 remove hardcoded colors

Revision c4685625 (diff)
Added by Jared Dillard over 3 years ago

Ticket #5905 remove hardcoded colors

Revision 3b53c227 (diff)
Added by Jared Dillard over 3 years ago

Ticket #5905 remove unused code

Revision 37d41653 (diff)
Added by Chris Buechler over 3 years ago

Shift the values to account for the removal of the gateways one. Ticket #5905

History

#1 Updated by Jim Thompson over 3 years ago

  • Assignee set to Steve Beaver
  • Target version changed from 2.3 to 2.4.0
  • Affected Version set to 2.3

#2 Updated by Steve Beaver over 3 years ago

I think I made those defines about a year ago. Problem is Bootstrap gives us only four colors and they are fairly dense/saturated. The pastel colors used in 2.2.x just seemed better suited to shading a table cell. What do you think?

We could substitute class names and CSS ifthat makes people feel better.

#3 Updated by Steve Beaver over 3 years ago

  • Status changed from New to Feedback
  • Assignee changed from Steve Beaver to Jared Dillard
  • Priority changed from Normal to Low

#4 Updated by Jared Dillard over 3 years ago

  • Status changed from Feedback to Resolved

Fixed the following files:

/src/usr/local/www/includes/functions.inc.php
/src/usr/local/www/status_gateway_groups.php
/src/usr/local/www/status_gateways.php
/src/usr/local/www/status_lb_pool.php
/src/usr/local/www/status_lb_vs.php

#5 Updated by NOYB NOYB over 3 years ago

Revision 3b53c227
Added by Jared Dillard about 9 hours ago

Ticket #5905 remove unused code

That commit breaks the system information widget in at least 2 places.
Although the initial page loads fine. When it auto refreshes the CPU Type has extra line of info that appears to be CPU load, and state table size % is undefined.

#6 Updated by Chris Buechler over 3 years ago

  • Target version changed from 2.4.0 to 2.3

He just missed shifting the values to account for the removal of [8], fixed now.

Also available in: Atom PDF