Bug #5905
closed
Hard coded background colors on status_gateways.php
Added by Jared Dillard over 8 years ago.
Updated over 8 years ago.
Description
I noticed hardcoded background colors on status_gateways.php that haven't been converted to bootstrap classes (success, warning, etc) yet.
I did a grep for the color below and it showed some possible places where they might be hiding.
grep -rn "90EE90" returns:
/src/usr/local/www/includes/functions.inc.php:79: $bgcolor = "#90EE90"; // lightgreen
/src/usr/local/www/status_gateway_groups.php:68: define('LIGHTGREEN', '#90EE90');
/src/usr/local/www/status_gateways.php:67: define('LIGHTGREEN', '#90EE90');
/src/usr/local/www/status_lb_pool.php:74: define('LIGHTGREEN', '#90EE90');
/src/usr/local/www/status_lb_vs.php:65: define('LIGHTGREEN', '#90EE90');
- Assignee set to Anonymous
- Target version changed from 2.3 to 2.4.0
- Affected Version set to 2.3
I think I made those defines about a year ago. Problem is Bootstrap gives us only four colors and they are fairly dense/saturated. The pastel colors used in 2.2.x just seemed better suited to shading a table cell. What do you think?
We could substitute class names and CSS ifthat makes people feel better.
- Status changed from New to Feedback
- Assignee changed from Anonymous to Jared Dillard
- Priority changed from Normal to Low
- Status changed from Feedback to Resolved
Fixed the following files:
/src/usr/local/www/includes/functions.inc.php
/src/usr/local/www/status_gateway_groups.php
/src/usr/local/www/status_gateways.php
/src/usr/local/www/status_lb_pool.php
/src/usr/local/www/status_lb_vs.php
Revision 3b53c227
Added by Jared Dillard about 9 hours ago
Ticket #5905 remove unused code
That commit breaks the system information widget in at least 2 places.
Although the initial page loads fine. When it auto refreshes the CPU Type has extra line of info that appears to be CPU load, and state table size % is undefined.
- Target version changed from 2.4.0 to 2.3
He just missed shifting the values to account for the removal of [8], fixed now.
Also available in: Atom
PDF