Project

General

Profile

Actions
Copy link

Bug #5976

closed
RB RB

Load cryptodev as a kernel module

Bug #5976: Load cryptodev as a kernel module

Added by Renato Botelho over 10 years ago. Updated over 9 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Renato Botelho
Category:
Operating System
Target version:
2.4.0
Start date:
03/11/2016
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
Affected Architecture:

Description

Remove cryptodev from kernel and build it as a module

CB Updated by Chris Buechler over 10 years ago Actions
Copy link
 #1

  • Target version changed from 2.3.1 to 2.3.2

CB Updated by Chris Buechler about 10 years ago Actions
Copy link
 #2

  • Target version changed from 2.3.2 to 2.4.0

RB Updated by Renato Botelho over 9 years ago Actions
Copy link
 #3

  • Status changed from New to Rejected

IPsec is builtin GENERIC kernel even in FreeBSD and it depends of crypto. This change doesn't make sense anymore

RB Updated by Renato Botelho over 9 years ago Actions
Copy link
 #4

  • Status changed from Rejected to Assigned

reopening since crypto is not cryptodev. Pointy hat to me

RB Updated by Renato Botelho over 9 years ago Actions
Copy link
 #5

  • Status changed from Assigned to Feedback
  • % Done changed from 0 to 100

Applied in changeset commit:69860ee4f5ff9f1e5b87bc6fdcb6dfea66062726.

JP Updated by Jim Pingle over 9 years ago Actions
Copy link
 #6

I just pushed a GUI change to add it in as a choice next to aesni. Testing revealed no benefit to having both aesni and cryptodev loaded together, so having an option for just one or the other is OK for the time being. It actually lowered performance instead of raising it.

I also added upgrade code so that the cryptodev module would be loaded for users upgrading from previous versions. Since it was in the kernel before, this seemed to be the best POLA-friendly course of action.

→L Updated by → luckman212 over 9 years ago Actions
Copy link
 #7

Had to look up POLA :)
In case I wasn't the only one:
https://en.m.wikipedia.org/wiki/Principle_of_least_astonishment

JP Updated by Jim Pingle over 9 years ago Actions
Copy link
 #8

  • Status changed from Feedback to Resolved

Works as expected. Upgrading users that did not have aesni enabled will have cryptodev loaded on upgrade or with a new install.

Actions
Copy link

Also available in: Atom