Project

General

Profile

Bug #5976

Load cryptodev as a kernel module

Added by Renato Botelho over 3 years ago. Updated over 2 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Renato Botelho
Category:
Operating System
Target version:
2.4.0
Start date:
03/11/2016
Due date:
% Done:

100%

Estimated time:
Affected Version:
Affected Architecture:

Description

Remove cryptodev from kernel and build it as a module

Associated revisions

Revision 69860ee4 (diff)
Added by Renato Botelho over 2 years ago

Fix #5976: build cryptodev as a module

Revision 2c98383f (diff)
Added by Jim Pingle over 2 years ago

Add GUI components for loading cryptodev as a module, and upgrade code so users have it on upgrade since it was in-kernel before. Fixes #5976
Having both aesni and cryptodev loaded at the same time appears to only negatively impact performance, no gains, so at the moment there is no need to load them at the same time.

History

#1 Updated by Chris Buechler over 3 years ago

  • Target version changed from 2.3.1 to 2.3.2

#2 Updated by Chris Buechler about 3 years ago

  • Target version changed from 2.3.2 to 2.4.0

#3 Updated by Renato Botelho over 2 years ago

  • Status changed from New to Rejected

IPsec is builtin GENERIC kernel even in FreeBSD and it depends of crypto. This change doesn't make sense anymore

#4 Updated by Renato Botelho over 2 years ago

  • Status changed from Rejected to Assigned

reopening since crypto is not cryptodev. Pointy hat to me

#5 Updated by Renato Botelho over 2 years ago

  • Status changed from Assigned to Feedback
  • % Done changed from 0 to 100

#6 Updated by Jim Pingle over 2 years ago

I just pushed a GUI change to add it in as a choice next to aesni. Testing revealed no benefit to having both aesni and cryptodev loaded together, so having an option for just one or the other is OK for the time being. It actually lowered performance instead of raising it.

I also added upgrade code so that the cryptodev module would be loaded for users upgrading from previous versions. Since it was in the kernel before, this seemed to be the best POLA-friendly course of action.

#7 Updated by Luke Hamburg over 2 years ago

Had to look up POLA :)
In case I wasn't the only one:
https://en.m.wikipedia.org/wiki/Principle_of_least_astonishment

#8 Updated by Jim Pingle over 2 years ago

  • Status changed from Feedback to Resolved

Works as expected. Upgrading users that did not have aesni enabled will have cryptodev loaded on upgrade or with a new install.

Also available in: Atom PDF