Project

General

Profile

Bug #6081

DNS Forwarder/Edit Host Override, alias edit buton does not edit correct alias

Added by Pi Ba about 3 years ago. Updated about 3 years ago.

Status:
Resolved
Priority:
Normal
Category:
DNS Forwarder
Target version:
Start date:
04/06/2016
Due date:
% Done:

0%

Estimated time:
Affected Version:
2.3
Affected Architecture:
All

Description

DNS Forwarder/Edit Host Override, alias edit buton does not edit correct alias

When 2 host overrides A and B are registered, then add a alias B-alias and save it.
Press the edit button for B-alias, now incorrectly host override A is shown.

History

#1 Updated by Jim Thompson about 3 years ago

  • Assignee set to Steve Beaver

#2 Updated by Phillip Davis about 3 years ago

Yes, a bug with reusing an index variable again in the inner loop for the aliases. If you enter lots of aliases then the edit button on each one takes you to override index 0, 1, 2, 3...
https://github.com/pfsense/pfsense/pull/2849

I also checked services_unbound.php DNS Resolver. The code there implements the index var differently and has been written OK, it does not have this bug.

#3 Updated by Chris Buechler about 3 years ago

  • Status changed from New to Feedback
  • Assignee changed from Steve Beaver to Chris Buechler

merged. Keyword "Redmine #xx" doesn't match redmine's ticket association. Commit 231197bbeb926323362918f8b27c20bb57059eea

#4 Updated by Chris Buechler about 3 years ago

  • Status changed from Feedback to Resolved

fixed

Also available in: Atom PDF