Bug #6101
closed
Alias/NTP/uPNP/other Edit add and then delete of new rows issue
Added by Phillip Davis over 8 years ago.
Updated over 8 years ago.
Description
Case 1:
a) Edit an existing Alias with n entries - rows 1 to n are displayed, good.
b) Press the Add button, enter data into 1 or more new rows.
c) Decide that you do not want one of those new rows - press its Delete button.
Expected result: The new row disappears.
Actual result: Row n disappears (the last of the original rows)
Case 2:
a) Add a new Alias - row 1 is displayed with no data in it, good.
b) Enter data into row 1
c) Press the Add button, enter data into 1 or more new rows.
d) Decide that you do not want one of those new rows - press its Delete button.
Expected result: The new row disappears.
Actual result: Row 1 disappears
This is "disconcerting" for users, and results in unintended data loss/modification if users are doing add/delete of rows as they decide what they really want in the alias.
Reported in forum: https://forum.pfsense.org/index.php?topic=109554.0
- Status changed from New to Confirmed
- Assignee set to Anonymous
It is fixed by https://github.com/pfsense/pfsense/pull/2854
But Steve or someone should look to see if there are any other side-effects of the fix, because it is in the common JS code. Maybe it will fix a similar problem in other place also that have multi-row entry with real-time interactive add-delete of rows.
- Status changed from Confirmed to Feedback
- Assignee changed from Anonymous to Chris Buechler
Phil's patch has been tested and applied. Thanks!
It may be worth noting that this affects other pages as well - I discovered it on the UPnP settings page.
I considered opening a separate bug for the issue, but according to the note above the issue has already been addressed. Thanks, Phil!
The fix will apply to all pages that use this construct, including UPnP.
- Status changed from Feedback to Resolved
- Subject changed from Alias Edit add and then delete of new rows issue to Alias/NTP/uPNP/other Edit add and then delete of new rows issue
Also available in: Atom
PDF